Bug 467821 - ksysguardd crashed repeatedly after starting ksysguard with a buffer overflow detected
Summary: ksysguardd crashed repeatedly after starting ksysguard with a buffer overflow...
Status: RESOLVED DOWNSTREAM
Alias: None
Product: ksysguard
Classification: Unmaintained
Component: ksysguardd (other bugs)
Version First Reported In: 5.22.0
Platform: Fedora RPMs Linux
: NOR crash
Target Milestone: ---
Assignee: KSysGuard Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-26 17:54 UTC by Matt Fagnani
Modified: 2023-03-26 22:51 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Full trace of ksysguardd crash (3.62 KB, text/plain)
2023-03-26 17:54 UTC, Matt Fagnani
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Fagnani 2023-03-26 17:54:41 UTC
Created attachment 157597 [details]
Full trace of ksysguardd crash

SUMMARY

I'm using Plasma 5.27.3 on Wayland in a Fedora 38 KDE Plasma installation. I started ksysguard from ksysguard-5.22.0-8.fc38.x86_64. A crash notification appeared. gnome-abrt and coredumpctl showed that ksysguardd crashed repeatedly after starting ksysguard when lmSensors was being initalized. The function __GI___fortify_fail showed the error "buffer overflow detected" in frame 5 of the trace.

Core was generated by `/usr/bin/ksysguardd'.
Program terminated with signal SIGABRT, Aborted.
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, 
    no_tid=no_tid@entry=0) at pthread_kill.c:44
44            return INTERNAL_SYSCALL_ERROR_P (ret) ? INTERNAL_SYSCALL_ERRNO (ret) : 0;
(gdb) bt
#0  __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, 
    no_tid=no_tid@entry=0) at pthread_kill.c:44
#1  0x00007fd376a2bc03 in __pthread_kill_internal (signo=6, threadid=<optimized out>)
    at pthread_kill.c:78
#2  0x00007fd3769daaee in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26
#3  0x00007fd3769c387f in __GI_abort () at abort.c:79
#4  0x00007fd3769c460f in __libc_message (fmt=fmt@entry=0x7fd376b3f2e6 "*** %s ***: terminated\n")
    at ../sysdeps/posix/libc_fatal.c:150
#5  0x00007fd376abfb29 in __GI___fortify_fail (
    msg=msg@entry=0x7fd376b3f28c "buffer overflow detected") at fortify_fail.c:24
#6  0x00007fd376abe364 in __GI___chk_fail () at chk_fail.c:28
#7  0x00007fd376abdf45 in ___snprintf_chk (s=<optimized out>, maxlen=maxlen@entry=300, 
    flag=flag@entry=2, slen=slen@entry=36, format=format@entry=0x55ecb81b1f98 "lmsensors/%s/%s")
    at snprintf_chk.c:29
#8  0x000055ecb81a88d6 in snprintf (__fmt=0x55ecb81b1f98 "lmsensors/%s/%s", __n=300, 
    __s=<optimized out>) at /usr/include/bits/stdio2.h:54
#9  initLmSensors (sm=0x55ecb81b8190 <SensorModulList+336>)
    at /usr/src/debug/ksysguard-5.22.0-8.fc38.x86_64/ksysguardd/Linux/lmsensors.c:170
#10 0x000055ecb8195319 in initModules ()
    at /usr/src/debug/ksysguard-5.22.0-8.fc38.x86_64/ksysguardd/ksysguardd.c:467
#11 main (argc=<optimized out>, argv=<optimized out>)
    at /usr/src/debug/ksysguard-5.22.0-8.fc38.x86_64/ksysguardd/ksysguardd.c:558

The crash happened 264 times according to coredumpctl. I'm attaching the full trace.

STEPS TO REPRODUCE
1. Boot a Fedora 38 KDE Plasma installation updated to 2023-3-26 with the updates-testing repo enabled
2. Log in to Plasma on Wayland
3. Start ksysguard

OBSERVED RESULT
ksysguardd crashed repeatedly after starting ksysguard with a buffer overflow detected

EXPECTED RESULT
No crashes would happen.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 38
(available in About System)
KDE Plasma Version: 5.27.3
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION

Fedora 38 involved a change to use the build flag _FORTIFY_SOURCE=3  https://fedoraproject.org/wiki/Changes/Add_FORTIFY_SOURCE%3D3_to_distribution_build_flags That change might be involved in the buffer overflow being detected. This problem appears to have been reported at https://bugzilla.redhat.com/show_bug.cgi?id=2179990
Comment 1 Bug Janitor Service 2023-03-26 18:33:47 UTC
Thank you for the bug report!

However Plasma 5.22.0 is no longer eligible for support or maintenance from KDE; supported versions are 5.27, and 5.27 or newer. Please upgrade to a supported version as soon as your distribution makes it available to you. Plasma is a fast-moving project, and bugs in one version are often fixed in the next one.

If you need support for Plasma 5.22.0, please contact your distribution, who bears the responsibility of providing support for older releases that are no longer supported by KDE.

If you can reproduce the issue after upgrading to a supported version, feel free to re-open this bug report.
Comment 2 Bug Janitor Service 2023-03-26 18:33:48 UTC
Thank you for the bug report!

However Plasma 5.22.0 is no longer eligible for support or maintenance from KDE; supported versions are 5.27, and 5.27 or newer. Please upgrade to a supported version as soon as your distribution makes it available to you. Plasma is a fast-moving project, and bugs in one version are often fixed in the next one.

If you need support for Plasma 5.22.0, please contact your distribution, who bears the responsibility of providing support for older releases that are no longer supported by KDE.

If you can reproduce the issue after upgrading to a supported version, feel free to re-open this bug report.
Comment 3 Matt Fagnani 2023-03-26 22:51:46 UTC
This problem might be fixed by the commit lmsensors: Fix buffer size passed to snprintf at https://invent.kde.org/plasma/ksysguard/-/commit/cb52be2f743a6717355445889dd3e2e265ad75fa