Bug 467524 - Please give i18n context at "Query author" in src/viewer/irccontextmenus.cpp
Summary: Please give i18n context at "Query author" in src/viewer/irccontextmenus.cpp
Status: RESOLVED FIXED
Alias: None
Product: konversation
Classification: Applications
Component: ircview (show other bugs)
Version: Git
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: argonel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-18 13:03 UTC by Oliver Kellogg
Modified: 2023-11-27 06:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Kellogg 2023-03-18 13:03:39 UTC
On git master src/viewer/irccontextmenus.cpp function setupTopicHistoryMenu line 791,
I find that the i18n string "Query author" may be ambiguous:

1) The author of a query is ... (filled by the program)
2) Give user the possibility for putting a question to an author
3) Ask the program for information about an author

Which of these interpretations is intended?
Please provide i18n context info.
Comment 1 argonel 2023-03-27 06:33:37 UTC
Git commit e5f96268c234deec8771f4ae4fdfe1d4ff990903 by Eli MacKenzie.
Committed on 27/03/2023 at 06:28.
Pushed by argonel into branch 'release/23.04'.

Adds an i18n context to the topic editor OpenQuery action

The term "query" is used in IRC clients to refer to a private message
window, which could be ambiguous to those that do not use IRC.

M  +1    -1    src/viewer/irccontextmenus.cpp

https://invent.kde.org/network/konversation/commit/e5f96268c234deec8771f4ae4fdfe1d4ff990903
Comment 2 argonel 2023-11-26 22:07:05 UTC
Git commit 9c1e10c32cef9e96f3dbcf517d778c85cf3dfeee by Eli MacKenzie.
Committed on 26/11/2023 at 23:03.
Pushed by argonel into branch 'master'.

Adds an i18n context to the topic editor OpenQuery action

The term "query" is used in IRC clients to refer to a private message
window, which could be ambiguous to those that do not use IRC.
(cherry picked from commit e5f96268c234deec8771f4ae4fdfe1d4ff990903)

This was intended to be merged to master prior to 23.08 but was missed,
so it does not exist in that version.

M  +1    -1    src/viewer/irccontextmenus.cpp

https://invent.kde.org/network/konversation/-/commit/9c1e10c32cef9e96f3dbcf517d778c85cf3dfeee
Comment 3 Oliver Kellogg 2023-11-27 06:21:20 UTC
Many thanks, the context makes it crystal clear.