Bug 467319 - KDE Partition Manager is using the same icon as Gparted and it's confusing
Summary: KDE Partition Manager is using the same icon as Gparted and it's confusing
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: Icons (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: visual-design
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-14 08:43 UTC by John
Modified: 2023-03-14 22:02 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.105


Attachments
Both KDE Partition Manager and Gparted opened (129.49 KB, image/png)
2023-03-14 08:43 UTC, John
Details
attachment-560067-0.html (119 bytes, text/html)
2023-03-14 17:33 UTC, Andrius Štikonas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John 2023-03-14 08:43:49 UTC
Created attachment 157262 [details]
Both KDE Partition Manager and Gparted opened

SUMMARY
KDE Partition Manager is using the same icon as Gparted and it's confusing when you use both


STEPS TO REPRODUCE
1. Assuming that KDE Partition Manager is already installed, install Gparted too.
2. Pin them  to the task bar or open both of them
3. Try to figure out which is which without hovering them and waiting to see the tooltips

OBSERVED RESULT
Both KDE Partition Manager and Gparted use the same icon an you cannot differentiate between them just by looking at them.

EXPECTED RESULT
When they are both installed, I expect to see a visual difference between their icons so I don't waste my time to hover and wait to see which is which.
I think Gparted should be displayed with its own icon, like in other desktop environments and not the same that KDE Partition Manager uses.
Or at least, if they need o use the same icon, a K and a G letter should be ovelayed on the icon to see which is for which.
I don't remember if I opened KDE  Partition first and then Gparted so KDE Partition Manager's icon is on the left and Gparted's icon is on the right.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Seen on Debian 12 with the unstable repository and fully updated
I don't know if this is a KDE Partition Manager problem or a Gparted one, but I didn't know where it was better to open this bug report.
Comment 1 Nate Graham 2023-03-14 17:30:22 UTC
Seems like an issue with Breeze icons; we use the partitionmanager icon for Gparted. That's just wrong!
Comment 2 Andrius Štikonas 2023-03-14 17:33:00 UTC
Created attachment 157277 [details]
attachment-560067-0.html

Actually both KDE Partition Manager and Gparted are using icon from filelight.
Comment 3 Bug Janitor Service 2023-03-14 17:33:03 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/252
Comment 4 Nate Graham 2023-03-14 17:39:43 UTC
Even crazier! But Partition Manager is at least a 1st party app so we can hopefully do better there...
Comment 5 Nate Graham 2023-03-14 22:01:44 UTC
Git commit 1cdb8d5437ea539a15a46a64b3c75e14d61740c6 by Nate Graham.
Committed on 14/03/2023 at 21:45.
Pushed by ngraham into branch 'master'.

Delete false Gparted and Kwikdisk icons

They are simply clones of KDE Partition Manager's icon which is super
weird and confusing. If we want to theme 3rd-party apps, we need to be
respectful of their branding, not obliterate it in favor of our own.

Even with this commit, Partition Manager still suffers from this issue,
but that's because it doesn't have its own icon yet. We'll fix that,
then fix this issue for Partition Manager too.
FIXED-IN: 5.105

T  +32   -1    icons/apps/48/filelight.svg
D  +0    -32   icons/apps/48/gparted.svg
D  +0    -1    icons/apps/48/kwikdisk.svg
M  +1    -1    icons/apps/48/partitionmanager.svg

https://invent.kde.org/frameworks/breeze-icons/commit/1cdb8d5437ea539a15a46a64b3c75e14d61740c6
Comment 6 Nate Graham 2023-03-14 22:02:28 UTC
Git commit a3e2231e2e7d99483ef2f565fc0fcc135b74a886 by Nate Graham.
Committed on 14/03/2023 at 22:02.
Pushed by ngraham into branch 'kf5'.

Delete false Gparted and Kwikdisk icons

They are simply clones of KDE Partition Manager's icon which is super
weird and confusing. If we want to theme 3rd-party apps, we need to be
respectful of their branding, not obliterate it in favor of our own.

Even with this commit, Partition Manager still suffers from this issue,
but that's because it doesn't have its own icon yet. We'll fix that,
then fix this issue for Partition Manager too.
FIXED-IN: 5.105


(cherry picked from commit 1cdb8d5437ea539a15a46a64b3c75e14d61740c6)

T  +32   -1    icons/apps/48/filelight.svg
D  +0    -32   icons/apps/48/gparted.svg
D  +0    -1    icons/apps/48/kwikdisk.svg
M  +1    -1    icons/apps/48/partitionmanager.svg

https://invent.kde.org/frameworks/breeze-icons/commit/a3e2231e2e7d99483ef2f565fc0fcc135b74a886