Bug 467265 - Improvement: Current trackinfo not displayed when using a radio station
Summary: Improvement: Current trackinfo not displayed when using a radio station
Status: RESOLVED DUPLICATE of bug 417895
Alias: None
Product: Elisa
Classification: Applications
Component: general (show other bugs)
Version: 22.12.3
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-13 08:31 UTC by slartibart70
Modified: 2024-11-03 12:24 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Questionable check, already commented out by me (114.60 KB, image/png)
2024-09-03 22:10 UTC, Manuel Roth
Details
Screenshot of Elisa with the check commented out - Meta info is shown (176.86 KB, image/png)
2024-09-03 22:14 UTC, Manuel Roth
Details

Note You need to log in before you can comment on or make changes to this bug.
Description slartibart70 2023-03-13 08:31:49 UTC
Hi,
i am using audacious for live radio-stations and copied the stations over to elisa.
But, elisa does not show the current track information like audacious does.
This would be a very welcome addition (including a copy option for the track title currently playing)
Comment 1 Bug Janitor Service 2023-05-12 01:49:22 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/461
Comment 2 Manuel Roth 2024-09-03 22:10:56 UTC
Created attachment 173294 [details]
Questionable check, already commented out by me
Comment 3 Manuel Roth 2024-09-03 22:12:13 UTC
That the meta information of web radio is not shown is bugging me, too.

I debugged and found a questionable check that I don't understand. If I remove that check, stream information are shown. Can this check be removed?
Comment 4 Manuel Roth 2024-09-03 22:14:34 UTC
Created attachment 173295 [details]
Screenshot of Elisa with the check commented out - Meta info is shown
Comment 5 Bug Janitor Service 2024-09-21 21:22:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/628
Comment 6 Jack Hill 2024-10-22 18:43:49 UTC
Git commit c0754bde50db970abe67fb4580ac033f6da4ecfa by Jack Hill, on behalf of Manuel Roth.
Committed on 22/10/2024 at 18:38.
Pushed by jackh into branch 'master'.

Fix not showing metadata of webradio stream

Currently when playing a webradio stream with VLC backend, metadata like station name, and artist - title are not shown.

This is due to an unnecessary if-statement restricting changes only for MediaPlayList::ColumnsRoles::IsValidRole, CountRole and IsPlayingRole. The if statement can be safely removed because the following switch-case has a sensible default case.

M  +0    -4    src/mediaplaylist.cpp

https://invent.kde.org/multimedia/elisa/-/commit/c0754bde50db970abe67fb4580ac033f6da4ecfa
Comment 7 Jack Hill 2024-10-22 18:43:57 UTC
Git commit ddc51ffaea6a5cd93b70e322011c76104f0dfd04 by Jack Hill, on behalf of Manuel Roth.
Committed on 22/10/2024 at 18:38.
Pushed by jackh into branch 'master'.

Fix artist/title/station metadata for vlc http streams

The metadata of webradio streams contains several fields, sometimes with different usages. This code change aims to use Elisa's ColumnsRoles::ArtitestRole and ::TitleRole (song title) as good as possible.

Only for libvlc backend. Developed against AAC(+), MP3 and also OGG streams.

M  +1    -1    src/audiowrapper.h
M  +17   -3    src/audiowrapper_libvlc.cpp
M  +2    -2    src/manageaudioplayer.cpp

https://invent.kde.org/multimedia/elisa/-/commit/ddc51ffaea6a5cd93b70e322011c76104f0dfd04
Comment 8 Jack Hill 2024-10-27 13:05:39 UTC
*** This bug has been marked as a duplicate of bug 417895 ***
Comment 9 Bug Janitor Service 2024-11-01 16:10:38 UTC
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/elisa/-/merge_requests/638
Comment 10 Jack Hill 2024-11-03 12:24:22 UTC
Git commit aa451081a5e4b4dd1bc9ce015aa566ec94b13127 by Jack Hill, on behalf of Manuel Roth.
Committed on 03/11/2024 at 12:24.
Pushed by jackh into branch 'master'.

Using UTF-8 encoding for webradio stream metadata (VLC backend)

Tested using the following radio stations:

http://edge68.streamonkey.net/fho-hitradioohrlive/stream/

http://listen.radioking.com/radio/623869/stream/686722

M  +6    -3    src/audiowrapper_libvlc.cpp

https://invent.kde.org/multimedia/elisa/-/commit/aa451081a5e4b4dd1bc9ce015aa566ec94b13127