Bug 467219 - Effect stack: drag and drop reordering crash
Summary: Effect stack: drag and drop reordering crash
Status: CONFIRMED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (show other bugs)
Version: 22.12.3
Platform: macOS (DMG) macOS
: NOR crash
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2023-03-11 21:05 UTC by Andrew
Modified: 2024-10-27 09:13 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
steps to reproduce drag-and-drop track effect reorder crash (183.48 KB, video/mp4)
2024-01-11 18:52 UTC, Andrew
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew 2023-03-11 21:05:23 UTC
SUMMARY

Kdenlive crashes when trying to reorder effects with drag and drop

STEPS TO REPRODUCE

1. Add clip to timeline
2. Add multiple effects to clip effect stack
3. Drag any effect to change the stack order
4. Drop effect in new order

OBSERVED RESULT

Dragging appears as expected, with line indicating where the effect will be placed in the stack. Kdenlive crashes if the order of effects is changed. The intended change cannot be recovered when the project is reopened.

EXPECTED RESULT

A list of two effects would be reversed. Three or more is also easily understood.

SOFTWARE/OS VERSIONS
macOS: 12.6.3

ADDITIONAL INFORMATION
Comment 1 Andrew 2023-03-11 21:07:53 UTC
To be clear, drag and drop does not crash if the order is unchanged.
Comment 2 emohr 2024-01-03 12:04:48 UTC
Does this still happen with 23.08.4?
Comment 3 Andrew 2024-01-03 20:56:14 UTC
Yes it does, both in tracks and Master
Comment 4 Jean-Baptiste Mardelle 2024-01-11 18:34:09 UTC
I cannot reproduce. Could you maybe post a screenshot of your effect stack, giving details about which effect you drag where inside the stack and which effect you then drag to get the crash?
Comment 5 Andrew 2024-01-11 18:52:11 UTC
Created attachment 164821 [details]
steps to reproduce drag-and-drop track effect reorder crash

I hope this video is helpful
Comment 6 emohr 2024-01-17 17:34:33 UTC
Thank you for reporting. Yes, I can confirm this crash following our steps (using Kdenlive 23.08.4 on Mac).
Comment 7 emohr 2024-01-20 12:21:51 UTC
No crash on Windows and Linux. It seems a Mac issue only.
Comment 8 Jean-Baptiste Mardelle 2024-05-07 04:19:17 UTC
Git commit f5ab6310f24537ab5f9f826f7bba629e35881920 by Jean-Baptiste Mardelle.
Committed on 07/05/2024 at 04:18.
Pushed by mardelle into branch 'release/24.05'.

FIx crash dragging from effect stack to another sequence

M  +15   -42   src/effects/effectstack/view/collapsibleeffectview.cpp
M  +6    -6    src/effects/effectstack/view/collapsibleeffectview.hpp
M  +51   -14   src/effects/effectstack/view/effectstackview.cpp
M  +6    -1    src/effects/effectstack/view/effectstackview.hpp
M  +0    -2    src/timeline2/view/qml/Clip.qml
M  +2    -4    src/timeline2/view/qml/TrackHead.qml
M  +1    -2    src/timeline2/view/qml/timeline.qml

https://invent.kde.org/multimedia/kdenlive/-/commit/f5ab6310f24537ab5f9f826f7bba629e35881920