Bug 467215 - macOS 11.74 Big Sur: digikam crashes unexpectedly after launching G'MIC (theme settings relevant)
Summary: macOS 11.74 Big Sur: digikam crashes unexpectedly after launching G'MIC (them...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Editor-GmicQt (show other bugs)
Version: 7.10.0
Platform: macOS (DMG) macOS
: NOR crash
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-11 19:31 UTC by No_Planet_2
Modified: 2023-03-29 12:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.0.0
Sentry Crash Report:


Attachments
Krita crash log (137.43 KB, text/plain)
2023-03-12 09:53 UTC, No_Planet_2
Details
digicam crash log (214.78 KB, text/plain)
2023-03-12 10:00 UTC, No_Planet_2
Details
digikam 8.0.0 / gmic 3.2.2 crash log (91 bytes, text/plain)
2023-03-20 12:21 UTC, No_Planet_2
Details
digikam crashlog (20 bytes, text/plain)
2023-03-20 17:18 UTC, No_Planet_2
Details
Crash log 3rd attempt (217.12 KB, text/plain)
2023-03-20 17:22 UTC, No_Planet_2
Details

Note You need to log in before you can comment on or make changes to this bug.
Description No_Planet_2 2023-03-11 19:31:09 UTC
SUMMARY
digikam crashes unexpectedly after launching G'MIC and trying some of the filters in preview mode - without applying them.
Sorry, I can‘t find any crash log in the Console.app.

***


STEPS TO REPRODUCE
1.  open digikam
2. open an jpg image in the editor
3. choose G'MIC QT and preview some of its filters 

OBSERVED RESULT
digikam  crashes unexpectedly  

EXPECTED RESULT
digikam shows the preview of the filter w.o. crashing

SOFTWARE/OS VERSIONS
macOS 11.74 Big Sur on MBP 2012 (OpenCore Legacy Patcher)

ADDITIONAL INFORMATION
I regarded this behaviour with the current version of digikam, 7.9.0 and thus tried 7.10.0 – with the equal result.
On the same machine runs GIMP 2.10.34 with G'MIC 2.7.5 flawlessly.
Comment 1 caulier.gilles 2023-03-11 21:18:41 UTC
The gmic qt from digiKam is a recent version : 3.2

Your gmicqt from gimp is very old.

*** This bug has been marked as a duplicate of bug 422996 ***
Comment 2 caulier.gilles 2023-03-11 21:20:49 UTC
what's about krita which include also gmicqt ?
Comment 3 No_Planet_2 2023-03-12 09:53:35 UTC
Created attachment 157205 [details]
Krita crash log

Kreta behaves the same way as digicam does: it crashes if I intend to use G'MIC.
Comment 4 No_Planet_2 2023-03-12 10:00:10 UTC
Created attachment 157206 [details]
digicam crash log

I tried it on my other machine, also running 11.7.4 (20G1120) Big Sur and it generated a crash log for digicam as well.
Comment 5 caulier.gilles 2023-03-12 13:21:03 UTC
Yes Krita has exactly the same problem than digiKam with GMicQt. It use a similar version of GmicQt than digiKam.

I suspect a GmicQt problem under MacOS, not a problem with the client application.

I know that GMicQt can be also used as a stand alone application. Perhaps GMicQt team provide a MacOS version, ready to use, and of course ready to test to see if the problem is well located in GMicQt module.

Best 

Gilles Caulier
Comment 6 caulier.gilles 2023-03-12 13:23:41 UTC
DOWNSTREAM bug from GMic Qt : 

https://github.com/c-koi/gmic-qt/issues/160

Gilles Caulier
Comment 7 No_Planet_2 2023-03-12 19:21:43 UTC
Many thanks for the link, Gilles! 

You are right, it looks like a specific G'Mic bug indeed, so the issue can be closed from my view.

I am glad that my old version in Gimp continues to work well, although X11 is not on my computer. 
https://github.com/c-koi/gmic-qt/issues/160#issuecomment-1465200447

Am also glad to have dipped a little into Debian, there are no problems.

A standalone for macOS would be great, but I have little hope...

Best
Martin
Comment 8 caulier.gilles 2023-03-17 06:57:01 UTC
See my comment https://bugs.kde.org/show_bug.cgi?id=422996#c32
Comment 9 caulier.gilles 2023-03-18 10:46:53 UTC
Git commit 8d86963ec06d56e9fb8e96df3c149abaf20a1c4b by Gilles Caulier.
Committed on 18/03/2023 at 10:44.
Pushed by cgilles into branch 'master'.

Increase stack size under Windows and MacOS to prevent crash with Gmic-qt
Related: bug 422996

M  +4    -0    core/CMakeLists.txt
A  +29   -0    core/cmake/rules/RulesMacOS.cmake
M  +14   -2    core/cmake/rules/RulesWindows.cmake

https://invent.kde.org/graphics/digikam/commit/8d86963ec06d56e9fb8e96df3c149abaf20a1c4b
Comment 10 No_Planet_2 2023-03-18 21:41:58 UTC
Thanks for the effort, which felt first brought a slight improvement, at least in the preview of the effects. Just updated digikam to version 8.0.0, but the crashes occur not only in the menu 'Colors' unchanged., also in Arrays and tiles etc.. Sometimes only when you apply the filter. Therefore I loaded the external data from G'MIC (about/download external data), unfortunately without effect.
Comment 11 caulier.gilles 2023-03-19 07:37:23 UTC
update cimg/gmic/gmic-qt to last v3.2.2 :

https://github.com/cgilles/gmic-qt/commit/b00dccd0d003bd46c800a4141e9988495ad3fe47
Comment 12 caulier.gilles 2023-03-19 09:14:36 UTC
Hi,

Color tools from Gmic-Qt do not crash on my macbbok pro intel using Ventura. Try the last 8.0.0 pre-release bundle published today. I updated *gmic* to last 3.2.2...

Gilles
Comment 13 caulier.gilles 2023-03-19 11:23:12 UTC
The Mixer-lab filter running on Ventura Intel:

https://i.imgur.com/NKvcEOS.png
Comment 14 caulier.gilles 2023-03-20 06:09:38 UTC
The PKG 8.0.0 pre-release installer must have the last crash fixed, i think. Please try and report me...

Best

Gilles
Comment 15 No_Planet_2 2023-03-20 12:04:17 UTC
Many thanks again, Gilles! I just installed G'MIC 3.2.2 / digikam 8.0.0 and tried several filters without any crash. So I logged in here to report you success –  but after switching back to digikam it still has been crashed silently. Will try this on my other machine which generates reports.

Best
Martin
Comment 16 No_Planet_2 2023-03-20 12:21:11 UTC
Created attachment 157442 [details]
digikam 8.0.0 / gmic 3.2.2 crash log
Comment 17 caulier.gilles 2023-03-20 15:30:51 UTC
I don't have this kind of crash using the PKG build today morning, where i fixed a mess inside the plugin.

Just double check please...

Gilles
Comment 18 caulier.gilles 2023-03-20 15:31:40 UTC
Your crash log from 20-03-2020 is ... empty...
Comment 19 No_Planet_2 2023-03-20 17:18:23 UTC
Created attachment 157450 [details]
digikam crashlog
Comment 20 No_Planet_2 2023-03-20 17:22:35 UTC
Created attachment 157451 [details]
Crash log 3rd attempt

Sorry for the empty log!
Comment 21 caulier.gilles 2023-03-20 21:04:51 UTC
ok, i seen.

The crash appears in the theme settings from the plugin. I seen this tab from Krita version of Gmic-Qt that all the panel have been disabled, probably because the code in Gmic-qt do something wrong about to applu the color theme (here Dark one).

I will need probably to do the same in the digiKam version.

Gilles Caulier
Comment 22 caulier.gilles 2023-03-21 05:05:50 UTC
Must be fixed with this commit : 

https://github.com/cgilles/gmic-qt/commit/f3cb5a4cf8d7cfd8649fed109c056b19718ea7ea

I recompile Macos 8.0.0 pre-release bundle now...

Gilles Caulier
Comment 23 caulier.gilles 2023-03-21 06:38:31 UTC
New PKG is available. Theme settings is now disabled in Gmicqt config dialog

https://i.imgur.com/hpdElbE.png

Gilles
Comment 24 caulier.gilles 2023-03-23 04:50:06 UTC
This file is now fixed with next 8.0.0 release.
Comment 25 caulier.gilles 2023-03-26 08:28:30 UTC
Hi No_Planet_2

I write a G'MIC-Qt chapter in the digiKam online documentation. If you can take a look and give me a feedback, it will be very appreciate:

https://docs.digikam.org/en/image_editor/enhancement_tools.html#g-mic-qt-tool

Thanks in advance

Gilles Caulier
Comment 26 No_Planet_2 2023-03-26 18:24:47 UTC
Hats off, Gilles. Describing G'MIC is a real painstaking job. I can only say: Thumbs up! One thing perhaps: The menu item About/Download external data could possibly be of importance for travelers, as well as the possibility to load new filter definitions via internet. I couldn't find out anything about that, because G'MIC is much less documented than digikam ;-).

But the jpfleury.github.io link is very helpful. Thanks!
Greetings, Martin
Comment 27 caulier.gilles 2023-03-28 09:31:45 UTC
Git commit cfc86130cbcd95b24f2b57faadc790ae00d0ea59 by Gilles Caulier.
Committed on 28/03/2023 at 09:30.
Pushed by cgilles into branch 'master'.

add words about Gmic-qt "About/Download external data" entry

M  +1    -1    image_editor/enhancement_tools.rst

https://invent.kde.org/documentation/digikam-doc/commit/cfc86130cbcd95b24f2b57faadc790ae00d0ea59
Comment 28 No_Planet_2 2023-03-28 20:25:36 UTC
I find this very well solved, the second version is more precise. But it's probably beyond the scope of digikam's 'manpages' to go into the peculiarities of G'MIC that only insiders might know about.  Pity.







_____

OT:

I'm probably interpreting this in layman's terms, but I see *two* options in G'MIC to load external data updated via the web:

1. via the reload button to the left of the text 'Internet' under the filter column, i.e. the middle column. I guess this is just the basic filter settings as plain text.
2. via the about/download external data menu, where you are warned that large amounts of data (about 85MB:) might be involved.
In both cases probably no executable code is updated, otherwise this would not work under a prehistoric G'MIC 2.7.3 with current GIMP 2.10.34.
And that also only with a patched mbp 2012 (OpenCore Legacy Patcher) running 11.7.5. but *not* with a Mini 2014 with the same macOS *without* the patch (SIP enabled, SSV disabled)
Apple, I hear you trapsen...
Comment 30 caulier.gilles 2023-03-29 12:57:06 UTC
About the "update" capabilities from Gmic-Qt, i already seen these different entries in the GUI. I not yet sure for each features, i will investigate the source code in-deep, and update the online doc accordingly.

Note : i implement a Batch Queue Manager digiKam plugin with G'MIC-Qt. It's not simple as the code is not so far adapted for that, but i progress:

https://i.imgur.com/mk9Op1C.png

Gilles