Bug 466992 - KDE Partition Manager shows the partition name as label and doesn't allow you to change one
Summary: KDE Partition Manager shows the partition name as label and doesn't allow you...
Status: RESOLVED FIXED
Alias: None
Product: partitionmanager
Classification: Applications
Component: general (show other bugs)
Version: 22.12.3
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-07 06:21 UTC by John
Modified: 2023-03-24 18:16 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 23.08.0
Sentry Crash Report:


Attachments
Partitions with names and labels set and a partition properties window opened (92.91 KB, image/png)
2023-03-07 06:21 UTC, John
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John 2023-03-07 06:21:48 UTC
Created attachment 157075 [details]
Partitions with names and labels set and a partition properties window opened

SUMMARY
KDE Partition Manager shows the partition name as label in its UI (both in column headers and properties window)
And it doesn't allow you the create / edit / delete a partition name.


STEPS TO REPRODUCE
1. Use GParted
2. Create or use a GPT partition table on some disk
3. Create a BTRFS partition and fill both the name an label fields with something unique that helps you differentiate later which is which. 

OBSERVED RESULT
My root partition has:
Name: Linux-name
Label: Linux-label
My home partition has:
Name: Home-name
Label: Home-label

And GParted, with which I created the partition table and partitions, giving them names and labels before installing the OS, shows them in the proper columns similar to the fields where they were created.
1. All the partition names under a column named "Name"
2. All the partition labels under a column named "Label"
3. Both the name and the label can be added or edited later from the context menu. For mounted partitions only after version 1.4.0

There was a bug that didn't allow  to to this  on mounted file systems before this version:
https://gparted.org/news.php?item=243

While KDE Partition Manager shows them in a confusing manner, not similar to the fields where they were created
1. All the partition names under a column named "Partition Label"
2. All the partition labels under a column named "Label"
3. Only the label can be added or edited later from the properties window



EXPECTED RESULT
1. I expect that all partition names are shown under a column named "Name",  instead of "Partition label" how it is now.
2. I expect that when I open the context menu on a partition and click on "Properties" item, I see a row there named "Name" instead of "Partition label" how it is now. This is confusing since we already have label, which of course it's a partition label since we're talking about partitions, same as with the columns.
3. I expected that the name can be added or edited if it's already there, similar to how you can do with the label

Optional but nice if possible:
4. I expect to have in the Properties window, the Name field immediately after the Label field to quickly be able to see them both and add or edit them and because to me they are logically related by being a type of a user-friendly description of that partition.
5. If Label remains the first field of this description and Name immediately after it, I expect a "Copy label" button next to name field, if possible, to be able to quickly use the same name if I want to do that. 

If 4.  it's not possible, because they are grouped like in Gparted properties window (File system and Partition), then I would like to see groups labels too, as those horizontal lines are not clear not me at all on what sections they want to separate.

Maybe you can do something like the fieldset / legend in HTML:
https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_fieldset
To me that would be more clear which are part of which, even though it would not help much to understand if the name or label is more useful or supported or I should just continue to add them both.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
KDE Plasma Version: 5.27.2 
KDE Frameworks Version: 5.103
Qt Version: 5.15.8

ADDITIONAL INFORMATION
For my installation I named and labeled the partitions and used the "-name" and "-label" suffixes to be more clear to me which ones are displayed in Dolphin and used anywhere else and as a good way to learn how Linux works.
Leaving them empty or typing the same thing in both would've made my learning process harder.
Comment 1 Paul Worrall 2023-03-07 09:00:16 UTC
Agree.  

GPT partitions have a "PartitionName"  (https://uefi.org/specs/UEFI/2.10/05_GUID_Partition_Table_Format.html#gpt-partition-entry-array)

Filesystems generally have a "Label" or "Volume Label" (man mkfs.btrfs, .ext4, etc.)

Partition Manager should follow this terminology
Comment 2 Andrius Štikonas 2023-03-07 20:07:57 UTC
(In reply to Paul Worrall from comment #1)
> Agree.  
> 
> GPT partitions have a "PartitionName" 
> (https://uefi.org/specs/UEFI/2.10/05_GUID_Partition_Table_Format.html#gpt-
> partition-entry-array)
> 
> Filesystems generally have a "Label" or "Volume Label" (man mkfs.btrfs,
> .ext4, etc.)
> 
> Partition Manager should follow this terminology

There seems to be a bit of a mess with label vs name for partitions...

Hmm, I think I followed terminology used by lsblk:
$ lsblk -o PARTLABEL  /dev/sda1
PARTLABEL
EFI System

lsblk is part of util-linux package. Yet fdisk which is also from util-linux uses Partition Name.

I guess this confusion in therminology is because they are essentially the same thing, just at different levels, one is a string at partition level, the other at file system level.

That said, if people feel strongly that this should be partition name, we can change it.

Support for actually editing parition names is not wired into GUI (if I remember correctly kpmcore library has implemented required functions, but it's not exposed in GUI). Anyway, this is a duplicate of 443197, so any discussion for this point should be there.
Comment 3 Andrius Štikonas 2023-03-12 00:34:00 UTC
1. Fixed
2. Fixed
3 This is already reported as 443197.

4 and 5 are kind of blocked by 3 (in any case best done together). I mentioned this bug in 443197, so I'll close this fixed even though 3 is not yet fixed.
Comment 4 Andrius Štikonas 2023-03-24 18:16:11 UTC
Git commit 6f88ec0124fa7da45cd0c479829a66f7ddd41296 by Andrius Štikonas.
Committed on 12/03/2023 at 00:27.
Pushed by stikonas into branch 'master'.

Rename Partition Label to Partition Name

M  +1    -1    src/gui/partitionmanagerwidgetbase.ui
M  +1    -1    src/gui/partpropswidgetbase.ui

https://invent.kde.org/system/partitionmanager/commit/6f88ec0124fa7da45cd0c479829a66f7ddd41296