Bug 466936 - Make dates in History sidebar and dialog unselectable upon filtering
Summary: Make dates in History sidebar and dialog unselectable upon filtering
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-06 11:59 UTC by Schimon Jehudah
Modified: 2023-03-25 02:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 23.04.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Schimon Jehudah 2023-03-06 11:59:05 UTC
I often have URLs I want to erase from history.
For that, I use the filter bar.
Yet, upon filtered, I'm still allowed to select dates which prevents me to press Ctrl + A (Select All) and then Delete the resulted URLs.
Comment 1 Juraj 2023-03-25 02:26:41 UTC
Git commit 74cfccd69d7249f6380120e9a8c46c1566e0f7b6 by Juraj Oravec.
Committed on 25/03/2023 at 02:15.
Pushed by jurajo into branch 'release/23.04'.

History: Don't delete all items under dates when filtering
FIXED-IN: 23.04.0

Signed-off-by: Juraj Oravec <jurajoravec@mailo.com>

M  +5    -0    src/lib/history/historymodel.cpp
M  +1    -0    src/lib/history/historymodel.h
M  +1    -1    src/lib/history/historytreeview.cpp

https://invent.kde.org/network/falkon/commit/74cfccd69d7249f6380120e9a8c46c1566e0f7b6
Comment 2 Juraj 2023-03-25 02:27:15 UTC
Git commit 85f9990104f5d59458bfdf4693cf6a3b29016f22 by Juraj Oravec.
Committed on 25/03/2023 at 02:11.
Pushed by jurajo into branch 'master'.

History: Don't delete all items under dates when filtering
FIXED-IN: 23.04.0

Signed-off-by: Juraj Oravec <jurajoravec@mailo.com>

M  +5    -0    src/lib/history/historymodel.cpp
M  +1    -0    src/lib/history/historymodel.h
M  +1    -1    src/lib/history/historytreeview.cpp

https://invent.kde.org/network/falkon/commit/85f9990104f5d59458bfdf4693cf6a3b29016f22
Comment 3 Juraj 2023-03-25 02:31:07 UTC
Hello,

the "fix" is more like a workaround and just makes it so, that the items will not be deleted.
I know there is a way to properly manage what items are selected but I am not skilled at using that.

Best regards,
Juraj.