Bug 466572 - Plasma-welcome doesn't fit the screen on a PinePhone
Summary: Plasma-welcome doesn't fit the screen on a PinePhone
Status: RESOLVED FIXED
Alias: None
Product: Welcome Center
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-28 00:23 UTC by kde@warpspeed.dk
Modified: 2023-03-05 19:10 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-welcome/commit/7913b8b3eb1d57cefd3a5b2cd44f0ec20cd92236
Version Fixed In: 6.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description kde@warpspeed.dk 2023-02-28 00:23:06 UTC 
SUMMARY
Plasma-welcome is way oversized on a Pinephone running Plasma-Mobile

OBSERVED RESULT
The welcome screen is so much larger than the screen, that no contents can be read,
and buttons are not available.
Only luck is, that the skip button is reachable.

EXPECTED RESULT
Everything is readable on the screen.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.27.1
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Comment 1 Nate Graham 2023-02-28 17:15:41 UTC 
Pinephone screen is 720x1440, with a default scale factor of 2x, which means an effective scaled resolution of 360x720. So we need to fix in that.

Converting to GridUnits at the default font of Noto Sans 10pt (which results in an 18px GridUnit), this means a minimum size of 20x40 GridUnits.
Comment 2 Nate Graham 2023-02-28 18:20:36 UTC 
Working on this.
Comment 3 Bug Janitor Service 2023-03-05 04:14:08 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-welcome/-/merge_requests/69
Comment 4 Nate Graham 2023-03-05 19:10:13 UTC 
Git commit 7913b8b3eb1d57cefd3a5b2cd44f0ec20cd92236 by Nate Graham.
Committed on 05/03/2023 at 19:10.
Pushed by ngraham into branch 'master'.

Make the page layouts mobile-friendly

This app was developed for a desktop use case, but people are running it
on mobile devices too. Getting it in a better shape for that use case
turns out to not be very hard--mostly a matter of replacing long row
layouts with grid or column layouts, making graphics dynamically resize,
reducing margins a bit, etc.

This commit does not adapt the *content* for mobile use cases; for that,
see https://invent.kde.org/plasma/plasma-welcome/-/issues/13.
FIXED-IN: 6.0

M  +-    --    src/contents/assets/konqi-build.png
M  +-    --    src/contents/assets/konqi-kde-hi.png
M  +5    -5    src/contents/ui/main.qml
M  +2    -2    src/contents/ui/pages/Contribute.qml
M  +98   -87   src/contents/ui/pages/Discover.qml
M  +2    -2    src/contents/ui/pages/Donate.qml
M  +53   -33   src/contents/ui/pages/PowerfulWhenNeeded.qml
M  +1    -1    src/contents/ui/pages/SimpleByDefault.qml
M  +26   -21   src/contents/ui/pages/Welcome.qml
M  +1    -1    src/qml/GenericPage.qml
M  +10   -0    src/qml/PlasmaFeatureButton.qml

https://invent.kde.org/plasma/plasma-welcome/commit/7913b8b3eb1d57cefd3a5b2cd44f0ec20cd92236