Bug 466465 - No icons in panels for files/dirs
Summary: No icons in panels for files/dirs
Status: RESOLVED DUPLICATE of bug 462307
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: 2.8.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-26 10:16 UTC by Michael Konieczny
Modified: 2023-04-02 07:20 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
No icons in panel view. (302.88 KB, image/png)
2023-02-26 10:16 UTC, Michael Konieczny
Details
Wrong icon positioning at scale factor 1.5 (30.17 KB, image/png)
2023-03-08 11:16 UTC, Wladimir Palant
Details
Double-double spacing and artifacts from drawing (69.05 KB, image/png)
2023-03-08 11:31 UTC, Michael Konieczny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Konieczny 2023-02-26 10:16:15 UTC
Created attachment 156755 [details]
No icons in panel view.

After upgrade, icons disappeared. There's space for icons, but no icon, and the empty space is too wide. 
I've also removed krusaderrc file to start with fresh config, the same effect.
Please have a look at the attached screenshot.
Comment 1 Wladimir Palant 2023-03-08 11:16:23 UTC
Created attachment 157106 [details]
Wrong icon positioning at scale factor 1.5
Comment 2 Wladimir Palant 2023-03-08 11:19:31 UTC
According to https://forum.manjaro.org/t/no-icons-in-filelist-krusader-2-8-0-1/128019, this issue is scaling-related. I can confirm that running Krusader 2.8.0 with the following command “fixes” this issue:

> QT_SCREEN_SCALE_FACTORS="eDP-1=1" krusader

When running with scale factor 1.5, one can see the positioning of the icons being off, see the additional screenshot I attached. At scale factor 1.8 and above the icons disappear from view. Yet the horizontal space reserved for the icons continues to grow, there is way more space being reserved than necessary.
Comment 3 Michael Konieczny 2023-03-08 11:31:10 UTC
Created attachment 157107 [details]
Double-double spacing and artifacts from drawing

For some files sometimes the horizontal offset gets doubled. And there are some artifacts, like something is drawn at borders between rows. I have scaling set to 175%.
Comment 4 Michael Konieczny 2023-03-08 11:33:09 UTC
> QT_SCREEN_SCALE_FACTORS="eDP-1=1" krusader

Works for me, but all icons get shrinked, including main toolbar, which was OK.
Comment 5 Wladimir Palant 2023-03-08 12:57:39 UTC
I could verify this to be a side-effect of https://phabricator.kde.org/D29453. The issue goes away if AA_UseHighDpiPixmaps attribute is not set. The icons are a bit blurry then but at least the file icons show up correctly.
Comment 6 Wladimir Palant 2023-03-08 14:20:23 UTC
Further investigation showed that QItemDelegate will correctly consider devicePixelRatio when drawing a QIcon decoration but not when drawing a QPixmap. Krusader converts the former to the latter in order to dim icons, converting back makes the issue disappear.

There are probably more glitches left however, seeing how Krusader uses icon.width() and icon.height() when it should probably be using icon.deviceIndependentSize() instead.
Comment 7 Wladimir Palant 2023-03-08 15:04:07 UTC
Sorry, wrong link above. The change that caused this is actually https://invent.kde.org/utilities/krusader/-/merge_requests/36.
Comment 8 Nikita Melnichenko 2023-04-02 07:20:48 UTC

*** This bug has been marked as a duplicate of bug 462307 ***