Bug 466197 - Implement org.freedesktop.impl.portal.Secret
Summary: Implement org.freedesktop.impl.portal.Secret
Status: RESOLVED FIXED
Alias: None
Product: xdg-desktop-portal-kde
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: VHI wishlist
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-21 14:42 UTC by Daniel Rusek
Modified: 2024-04-26 03:07 UTC (History)
19 users (show)

See Also:
Latest Commit: https://invent.kde.org/frameworks/kwallet/-/commit/020427c8fb9d1dd6a41658131d1f80eee9171776
Version Fixed In: Frameworks 6.2
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Rusek 2023-02-21 14:42:08 UTC 
The org.freedesktop.impl.portal.Secret interface was added a few years ago into gnome-keyring. This interface is needed for org.freedesktop.portal.Secret in xdg-desktop-portal to allow Flatpak apps to store credentials correctly. Although KWallet supports org.freedesktop.secrets since 5.97, it does not work with Flatpak apps because of the org.freedesktop.impl.portal.Secret support missing.

Here are more information / implementation details from the xdg-desktop-portal developer: https://github.com/flatpak/xdg-desktop-portal/issues/970#issuecomment-1438351750
Comment 1 Bug Janitor Service 2023-09-24 18:22:55 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kwallet/-/merge_requests/67
Comment 2 Méven 2024-04-21 16:29:10 UTC 
Git commit 020427c8fb9d1dd6a41658131d1f80eee9171776 by Méven Car, on behalf of Nicolas Fella.
Committed on 21/04/2024 at 16:17.
Pushed by meven into branch 'master'.

Implement XDG Secrets Portal

This portal allows applications to obtain a master secret they can use to encrypt their data.

The secret is stored in KWallet.

If no secret exists yet a new one is generated

A  +66   -0    src/api/KWallet/org.freedesktop.impl.portal.Secret.xml
M  +7    -0    src/runtime/kwalletd/CMakeLists.txt
A  +4    -0    src/runtime/kwalletd/kwallet.portal
M  +3    -0    src/runtime/kwalletd/kwalletd.cpp
A  +99   -0    src/runtime/kwalletd/kwalletportalsecrets.cpp     [License: LGPL(v2.0+)]
A  +47   -0    src/runtime/kwalletd/kwalletportalsecrets.h     [License: LGPL(v2.0+)]

https://invent.kde.org/frameworks/kwallet/-/commit/020427c8fb9d1dd6a41658131d1f80eee9171776