Bug 466070 - 3.2.1.1 doesn't build against system gmic
Summary: 3.2.1.1 doesn't build against system gmic
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-19 11:17 UTC by Antonio Rojas
Modified: 2023-02-23 18:29 UTC (History)
2 users (show)

See Also:
Latest Commit: https://github.com/amyspark/gmic/commit/2d46603051ad3faa537f6589d1b03d46cdc7b969
Version Fixed/Implemented In: 3.2.1.2
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Rojas 2023-02-19 11:17:39 UTC 
Commit https://github.com/amyspark/gmic/commit/7b0e1f74199f8f605b69a759a2135077af7dd94c defines -Dgmic_core unconditionally. This breaks build against system gmic, as the gmic.h heades expects the gmic.cpp source file to be present at build time.

In file included from /build/krita-plugin-gmic/src/gmic-3.2.1.1-patched/gmic-qt/src/PersistentMemory.cpp:26:
/usr/include/gmic.h:191:21: fatal error: gmic.cpp: No such file or directory
  191 | #define cimg_plugin "gmic.cpp"
      |                     ^~~~~~~~~~
compilation terminated.
Comment 1 amyspark 2023-02-19 13:38:34 UTC 
This is an upstream bug: https://github.com/c-koi/gmic-qt/commit/f0d9d8acd10b89f9d28a49227f3c70ff1f2e18a5

Please file it with Sébastien, I'll add a patch in the meanwhile.
Comment 2 amyspark 2023-02-19 14:03:13 UTC 
Antonio, can you check if https://github.com/amyspark/gmic/pull/5 makes it work?