Bug 465951 - No visual indicator to show that checkboxes have focus
Summary: No visual indicator to show that checkboxes have focus
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_flatpak (show other bugs)
Version: 5.27.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: accessibility, usability
Depends on:
Blocks:
 
Reported: 2023-02-17 18:04 UTC by Jack Hill
Modified: 2023-03-04 03:24 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2023-02-17 18:04:51 UTC
SUMMARY

STEPS TO REPRODUCE
1. Open the Flatpak KCM
2. Click on an app
3. Press tab once
4. Press space

OBSERVED RESULT
The first checkbox should be toggled. There is nothing to indicate that the checkbox has focus

EXPECTED RESULT
Usually the corresponding label is underlined when it has focus.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230215
KDE Plasma Version: 5.27.0
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.10-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 Jack Hill 2023-02-17 18:13:04 UTC
Also, possibly related, using the mouse to toggle checkboxes doesn't update the current keyboard focus.

I expect to be able to click a checkbox, press tab, press enter, and the subsequent checkbox should be toggled.

Instead, the focus is not updated.
Comment 2 Nate Graham 2023-02-17 23:23:37 UTC
What seems to be happening is that the list item itself gets focus rather than the checkbox specifically, but we disabled the list item highlight effect. Since the list items do in fact do something when clicked (they toggle their checkbox), we should probably re-add it.
Comment 3 Bug Janitor Service 2023-03-03 19:03:59 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/flatpak-kcm/-/merge_requests/57
Comment 4 Nate Graham 2023-03-04 03:24:14 UTC
Git commit 00ed59163d416c88f9410802853e4ecdcb06bbd8 by Nate Graham.
Committed on 04/03/2023 at 03:22.
Pushed by ngraham into branch 'master'.

Re-add default list item highlight

Typically we remove these hover and highlight effects for list items
that arenon-interactive where hover and keyboard navigation don't make
sense.

But that's not the case here; these list items are interactive (clicking
them toggles their checkbox) and therefore keyboard navigation does make
sense.

Accordingly, let's stop removing the default list item hover and
highlight effects to make this interactivity obvious and allow keyboard
navigation to be usable.
FIXED-IN: 5.27.3

M  +0    -3    package/contents/ui/permissions.qml

https://invent.kde.org/plasma/flatpak-kcm/commit/00ed59163d416c88f9410802853e4ecdcb06bbd8
Comment 5 Nate Graham 2023-03-04 03:24:58 UTC
Git commit 09dc8ccce3dc1f2b57a7d4d38f9e4111b8af3c0a by Nate Graham.
Committed on 04/03/2023 at 03:24.
Pushed by ngraham into branch 'Plasma/5.27'.

Re-add default list item highlight

Typically we remove these hover and highlight effects for list items
that arenon-interactive where hover and keyboard navigation don't make
sense.

But that's not the case here; these list items are interactive (clicking
them toggles their checkbox) and therefore keyboard navigation does make
sense.

Accordingly, let's stop removing the default list item hover and
highlight effects to make this interactivity obvious and allow keyboard
navigation to be usable.
FIXED-IN: 5.27.3


(cherry picked from commit 00ed59163d416c88f9410802853e4ecdcb06bbd8)

M  +0    -3    package/contents/ui/permissions.qml

https://invent.kde.org/plasma/flatpak-kcm/commit/09dc8ccce3dc1f2b57a7d4d38f9e4111b8af3c0a