Created attachment 156383 [details] Outline for active window is not contrast colored SUMMARY *** I have nothing against the new window outline, but with a custom titlebar color the outline color looks unexpected: I use a light color scheme with the titlebars of my active windows green, and instead of a contrast of the background color (which would be the same as for inactive windows, whose outline is grey/black), the outline appears in a bright green which looks a bit off - see attachment. *** STEPS TO REPRODUCE 1. Use a color scheme with a custom active window titlebar color 2. Use Breeze window decoration OBSERVED RESULT Outline of active window is contrast of background color (same as for inactive windows) EXPECTED RESULT Outline of active window is a lighter version of the titlebar color SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.27.0 KDE Frameworks Version: 5.103.0 Qt Version: 5.15.8 Kernel Version: 6.1.12-arch1-1 (64-bit)
> EXPECTED RESULT > Outline of active window is a lighter version of the titlebar color Isn't that what you've got? Your titlebar is medium green and the outline is light green.
Yes... I got the expected and actual result the wrong way round.
I think this may be intentional, but I'll let Akseli confirm.
Yes, this is intentional. You can see the discussion about it here: https://invent.kde.org/plasma/breeze/-/merge_requests/241#note_533922
Ah okay. Looks kinda different though than in that screenshot: https://invent.kde.org/plasma/breeze/uploads/1be717c4c11422cff0878ded660a079a/Screenshot_20221001_025502.png This is the one you were going with, right? In your screenshot it looks like with a light color scheme the outline is a darker version of the titlebar color which I agree looks quite nice, but with my green the outline is brighter that that's what I thought looks kinda off in combination with the darker outline for inactive windows.
I wonder if something went wrong with the lighten/darken values that the outlines use. Maybe they're too strong? Need to look into that.
A possibly relevant merge request was started @ https://invent.kde.org/plasma/breeze/-/merge_requests/294
Git commit ca38e7058568a7f4a9167cb0af57f6e13e880273 by Natalie Clarius. Committed on 04/03/2023 at 17:55. Pushed by nclarius into branch 'kdecoration-outline-color-frame'. kdecoration: take outline color from frame color, not titlebar color It makes more sense to set contrast with the side borders (eg dark gray around a light color scheme) rather than with the already colorful titlebar (eg light green around a deep green titlebar and otherwise light colored window). M +1 -2 kdecoration/breezedecoration.cpp https://invent.kde.org/plasma/breeze/-/commit/ca38e7058568a7f4a9167cb0af57f6e13e880273
Git commit 093593fda69f639c2d96cc9174fdfc077b30ac27 by Natalie Clarius. Committed on 28/11/2023 at 22:55. Pushed by nclarius into branch 'master'. kdecoration: take outline color from frame color, not titlebar color It makes more sense to set contrast with the side borders (eg dark gray around a light color scheme) rather than with the already colorful titlebar (eg light green around a deep green titlebar and otherwise light colored window). M +1 -2 kdecoration/breezedecoration.cpp https://invent.kde.org/plasma/breeze/-/commit/093593fda69f639c2d96cc9174fdfc077b30ac27