Bug 465934 - Inline editing is broken
Summary: Inline editing is broken
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords: regression
: 466043 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-02-17 15:02 UTC by Nate Graham
Modified: 2023-02-27 08:02 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/network/neochat/commit/2dd3197beb13596162a4f8559405e430dd2cc14f
Version Fixed In:
Sentry Crash Report:

Attachments
It broke (230.86 KB, video/mp4)
2023-02-17 15:02 UTC, Nate Graham 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2023-02-17 15:02:10 UTC 
Created attachment 156375 [details]
It broke

Clicking on the edit button shows an empty text field. See screen recording, and apologies for the potato-quality video.

Regression from f785e4d5b0e77f3e28fdfc5891bb6f9b0e562649.
Comment 1 Bug Janitor Service 2023-02-17 17:12:20 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/803
Comment 2 James Graham 2023-02-20 18:07:38 UTC 
*** Bug 466043 has been marked as a duplicate of this bug. ***
Comment 3 James Graham 2023-02-20 18:25:15 UTC 
Fixed by https://invent.kde.org/network/neochat/-/merge_requests/803
Comment 4 James Graham 2023-02-27 08:02:30 UTC 
Git commit 2dd3197beb13596162a4f8559405e430dd2cc14f by James Graham.
Committed on 20/02/2023 at 18:24.
Pushed by nvrwhere into branch 'master'.

Inline Edit Fixes

- Make sure the connection to the room's chatBoxEditIdChanged signal is made so that the edit box gets filled.
- Make sure the minimum height and preferred width are available to the loader so they can be set and dynamically updated.

M  +3    -0    src/qml/Component/Timeline/MessageDelegate.qml
M  +15   -16   src/qml/Component/Timeline/MessageEditComponent.qml

https://invent.kde.org/network/neochat/commit/2dd3197beb13596162a4f8559405e430dd2cc14f