Bug 465788 - Inconsistent look and feel "OK / Cancel" order
Summary: Inconsistent look and feel "OK / Cancel" order
Status: RESOLVED FIXED
Alias: None
Product: KScreen
Classification: Plasma
Component: common (show other bugs)
Version: 5.27.0
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: kscreen-bugs-null@kde.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-15 19:41 UTC by dft
Modified: 2023-02-17 20:10 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.27.1
Sentry Crash Report:


Attachments
DisplayConfig - Should be Keep / Revert not Revert / Keep (46.81 KB, image/png)
2023-02-15 19:41 UTC, dft
Details

Note You need to log in before you can comment on or make changes to this bug.
Description dft 2023-02-15 19:41:21 UTC
Created attachment 156281 [details]
DisplayConfig - Should be Keep / Revert not Revert / Keep

SUMMARY
***
When changing settings the default in KDE is to have the OK on the left and Cancel on the right. The latest build of KDE 5.27 with KScreen swaps these around. This affects muscle memory and makes it inconsistent with KDE's overall operation.

Keep is the same as Ok
Revert is the same as Cancel

Therefore it should be Ok / Cancel and not Cancel / Ok to be consistent with KDE overall.

***


STEPS TO REPRODUCE
1. Right click wallpaper
2. Configure Display Settings
3.  Change anything eg scale and click apply.

OBSERVED RESULT
Windows pops up saying "Revert / Keep" 

EXPECTED RESULT
This should be "Keep / Revert"

SOFTWARE/OS VERSIONS
Operating System: ArcoLinux 
KDE Plasma Version: 5.27.0
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.12-1-cachyos-bore (64-bit)
Graphics Platform: Wayland
Processors: 32 × AMD Ryzen 9 5950X 16-Core Processor
Memory: 31.3 GiB of RAM
Graphics Processor: AMD Radeon RX 5700 XT
Manufacturer: Micro-Star International Co., Ltd.
Product Name: MS-7C91
System Version: 2.0

Atttached shows to dialogs, one from KDE and the other from Displayconfig.
Comment 1 Nate Graham 2023-02-17 20:07:06 UTC
Git commit f1da923305693423ffac87402f45ece0d076d8d1 by Nate Graham.
Committed on 17/02/2023 at 20:05.
Pushed by ngraham into branch 'master'.

kcm: Use correct role for revert button

ResetRole is to reset the *dialog* (not the UI it controls) to its
default values, which is not what we're using it for here. The correct
role is RejectRole.
FIXED-IN: 5.27.1

M  +1    -1    kcm/package/contents/ui/main.qml

https://invent.kde.org/plasma/kscreen/commit/f1da923305693423ffac87402f45ece0d076d8d1
Comment 2 Nate Graham 2023-02-17 20:09:54 UTC
Git commit 06f0671a8337a1c51cc6d6b29c3b1d258c311119 by Nate Graham.
Committed on 17/02/2023 at 20:09.
Pushed by ngraham into branch 'Plasma/5.27'.

kcm: Use correct role for revert button

ResetRole is to reset the *dialog* (not the UI it controls) to its
default values, which is not what we're using it for here. The correct
role is RejectRole.
FIXED-IN: 5.27.1
(cherry picked from commit f1da923305693423ffac87402f45ece0d076d8d1)

M  +1    -1    kcm/package/contents/ui/main.qml

https://invent.kde.org/plasma/kscreen/commit/06f0671a8337a1c51cc6d6b29c3b1d258c311119