Bug 465740 - If a floating tile is split nether splits can be deleted
Summary: If a floating tile is split nether splits can be deleted
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: Custom Tiling (show other bugs)
Version: 5.27.0
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-15 03:06 UTC by Nicholas Omann
Modified: 2023-03-17 17:29 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27.4
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas Omann 2023-02-15 03:06:50 UTC
SUMMARY
If you happen to split (in my case i had done it horizontally) a floating tile clicking delete on either split tile will close the layout designer rather then delete the split.


STEPS TO REPRODUCE
1. Add a floating tile
2. Split Horizontally
3. Press Delete

OBSERVED RESULT
Tiling layout manager closes.

EXPECTED RESULT
Split tile that delete was clicked on should be deleted.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.27.0
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Comment 1 Nicholas Omann 2023-02-15 03:09:08 UTC
Sorry for the quick comment but I have more information from testing. I did confirm same behavior when vertical is done instead and it's not just delete all the buttons for the split tile close the layout editor.
Comment 2 Bug Janitor Service 2023-02-15 15:49:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3606
Comment 3 David Edmundson 2023-02-15 23:05:30 UTC
Git commit 7b46f101e33f870a6116e04bd940b1113278bd44 by David Edmundson.
Committed on 15/02/2023 at 23:05.
Pushed by davidedmundson into branch 'master'.

Simplify tile dismissal

We want floating tiles to be activatable, but also dismiss the effect by
clicking on the whitespace.

The current solution doesn't work as a floating tile that is in turn
split will pull focus from the children meaning those tiles can't be deleted.

Rather than special casing and z-manipulation we can simplify everything
by moving tile dismissal to the root of the effect and appropariately
propagating the event.

M  +3    -3    src/effects/tileseditor/qml/TileDelegate.qml
M  +5    -0    src/effects/tileseditor/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/7b46f101e33f870a6116e04bd940b1113278bd44
Comment 4 postix 2023-03-13 19:45:51 UTC
Still experience this on

Operating System: openSUSE Tumbleweed 20230312
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Graphics Platform: Wayland
Graphics Processor: AMD Radeon RX 580 Series
Comment 5 Bug Janitor Service 2023-03-17 16:19:03 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3836
Comment 6 David Edmundson 2023-03-17 16:19:30 UTC
Seems it was never added to 5.27
Comment 7 postix 2023-03-17 16:33:57 UTC
(In reply to David Edmundson from comment #6)
> Seems it was never added to 5.27

Thanks David!
Comment 8 David Edmundson 2023-03-17 17:29:47 UTC
Git commit 0be551c6bf565a939e179e7b0533dfb165167120 by David Edmundson.
Committed on 17/03/2023 at 16:18.
Pushed by davidedmundson into branch 'Plasma/5.27'.

Simplify tile dismissal

We want floating tiles to be activatable, but also dismiss the effect by
clicking on the whitespace.

The current solution doesn't work as a floating tile that is in turn
split will pull focus from the children meaning those tiles can't be deleted.

Rather than special casing and z-manipulation we can simplify everything
by moving tile dismissal to the root of the effect and appropariately
propagating the event.


(cherry picked from commit 7b46f101e33f870a6116e04bd940b1113278bd44)

M  +3    -3    src/effects/tileseditor/qml/TileDelegate.qml
M  +5    -0    src/effects/tileseditor/qml/main.qml

https://invent.kde.org/plasma/kwin/commit/0be551c6bf565a939e179e7b0533dfb165167120