Bug 465696 - Option to override audio settings on entry to piano activity persists after activity has been left (even if user quits on initial dialog of piano activity)
Summary: Option to override audio settings on entry to piano activity persists after a...
Status: RESOLVED FIXED
Alias: None
Product: gcompris
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jazeix Johnny
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-14 03:24 UTC by ReadAlongToLearnEnglish
Modified: 2023-02-14 19:37 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description ReadAlongToLearnEnglish 2023-02-14 03:24:22 UTC
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
Entering the piano activity and choosing to continue playing sound overrides global sound settings after piano activity has been closed and another activity opened.  I expected choosing to override the audio on activity entry would only be while that activity is active. 


STEPS TO REPRODUCE
1.  Turn off Audio / Voices and Background music
2.  Enter Baby keyboard an press a few keys to confirm no noise heard
3. Enter Play Piano activity and choose to continue when prompted to override audio settings. ** See notes section below for more info
4.  Play notes on first level and confirm noise is heard.
5. Exit activity and return to global settings to confirm audio options for voices , effects and background music are off
6. Re-enter baby keyboard and press some keys

OBSERVED RESULT
Audio is playing.

EXPECTED RESULT
Audio does not play as global settings show no noise should be played. 

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma:  Ubuntu 20.04  GCompris v3.1 downloaded .sh file.
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
It was assumed that any audio override would only affect that activity. 

** even when you choose to quit out of the Play piano activity when the initial dialog appears, the system starts playing audio
Comment 1 Jazeix Johnny 2023-02-14 19:37:18 UTC
Git commit a52434fdd5cdae9e860c014d9502cbb5aa08b0a8 by Johnny Jazeix.
Committed on 14/02/2023 at 19:36.
Pushed by jjazeix into branch 'master'.

core, fix issue where all sounds after leaving musical activities are played when sounds are disabled in configuration.

M  +4    -0    src/core/main.qml

https://invent.kde.org/education/gcompris/commit/a52434fdd5cdae9e860c014d9502cbb5aa08b0a8
Comment 2 Jazeix Johnny 2023-02-14 19:37:36 UTC
Git commit 47064cc6a95938e960b0673db6128696c7f4ad94 by Johnny Jazeix.
Committed on 14/02/2023 at 19:37.
Pushed by jjazeix into branch 'KDE/3.0'.

core, fix issue where all sounds after leaving musical activities are played when sounds are disabled in configuration.

M  +4    -0    src/core/main.qml

https://invent.kde.org/education/gcompris/commit/47064cc6a95938e960b0673db6128696c7f4ad94