Bug 465628 - Country names in address editor are in English
Summary: Country names in address editor are in English
Status: REOPENED
Alias: None
Product: kontact
Classification: Applications
Component: contacts (show other bugs)
Version: 5.17.1
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-12 17:34 UTC by Christopher Yeleighton
Modified: 2023-02-12 17:48 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Yeleighton 2023-02-12 17:34:33 UTC
SUMMARY
Country names in the address editor are in English.  Country names in the address viewer are in Polish.


STEPS TO REPRODUCE
1. Tell Kontact to create a new contact!
2. Tell the new contact to add a new address!
3. Select a country!

OBSERVED RESULT
The countries are in English.

EXPECTED RESULT
Let the countries be in Polish!

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: openSUSE Tumbleweed 20230210
(available in About System)
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
The country list has been populated using raw QLocale::countryToString which returns English names.  It has then been sorted using QString::localeAwareCompare, i.e. using Polish locale.  The result of sorting English names in Polish locale is acceptable but the process seems fishy.
The country name displayed in the contact view pane is provided by KCountry.
There is no proof that Qt itself should be responsible for providing a localised country name.
Comment 1 Luigi Toscano 2023-02-12 17:43:53 UTC
No, the country name in the addresssbook editor is provided by Qt:
https://invent.kde.org/pim/akonadi-contacts/-/blob/master/src/contact-editor/editor/addresseditor/addresslocationwidget.cpp#L177
Comment 2 Christopher Yeleighton 2023-02-12 17:48:41 UTC
(In reply to Luigi Toscano from comment #1)
> No, the country name in the addresssbook editor is provided by Qt:
> https://invent.kde.org/pim/akonadi-contacts/-/blob/master/src/contact-editor/
> editor/addresseditor/addresslocationwidget.cpp#L177

Yes, and the country name provided in the address book viewer is provided by KDE.  We cannot expect Qt to provide a localised country name, that is why we implement the support for localised country names in our framework.  As much as I would like upstream to provide a localised country name, I do not think we should expect it to happen.   We have already acknowledged that in that we created our own class to provide the required functionality.