Bug 465422 - Two app icons drawn by Kirigami.Icon are rendered in black monochrome on home page of Discover, using the Qogir icon theme in Xfce
Summary: Two app icons drawn by Kirigami.Icon are rendered in black monochrome on home...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.102.0
Platform: Arch Linux Linux
: NOR minor
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords:
: 466453 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-02-07 13:56 UTC by mscaglione
Modified: 2023-08-05 15:48 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0


Attachments
Screenshot of Discover home page; KolourPaint and Krita icons fail to render (155.83 KB, image/png)
2023-02-07 13:56 UTC, mscaglione
Details

Note You need to log in before you can comment on or make changes to this bug.
Description mscaglione 2023-02-07 13:56:06 UTC
Created attachment 156029 [details]
Screenshot of Discover home page; KolourPaint and Krita icons fail to render

SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***


STEPS TO REPRODUCE
1. Have Qogir as the icon theme 
2. Open Discover

OBSERVED RESULT
The first two apps, namely KolourPaint and Krita, have their respective icons failing to render and instead showing a black patch.

EXPECTED RESULT
Having all the apps icons present on the Featured page render properly, since Qogir does include these two apps in the icon theme.

SOFTWARE/OS VERSIONS
Linux: latest (6.1.9)
Plasma: latest (5.26.5-1)
KDE Frameworks: latest (don't want to logout only to check version number or search for it on arch linux packages but it's the latest) 

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-02-07 20:12:46 UTC
This looks like that bug where Kirigami.Icon inappropriately makes the icon monochrome under mysterious conditions.
Comment 2 Nate Graham 2023-02-27 16:52:25 UTC
*** Bug 466453 has been marked as a duplicate of this bug. ***
Comment 3 Nate Graham 2023-05-14 13:32:02 UTC
Cannot reproduce in Plasma. I suspect the lack of plasma-integration is doing something weird here.

If you install plasma-integration, does it start working? Or no?
Comment 4 Bug Janitor Service 2023-05-29 03:45:11 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2023-06-13 03:45:24 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!
Comment 6 Nate Graham 2023-08-05 15:48:07 UTC
Git commit bdb322527fbc910ce7124a45dc43dfaa0fad1522 by Nate Graham.
Committed on 04/08/2023 at 16:58.
Pushed by ngraham into branch 'master'.

Icon: Remove automatic heuristic-based monochrome icon re-coloring

This feature has caused many bugs over the years and its value is
dubious to begin with. Automatically masking a colorful icon to instead
be monochrome based on this or that heuristic violates the integrity of
the user's icon theme and enforces a stylistic preference for monochrome
icons that is not appropriate to do at the library level.

If the user is using an icon theme whose icons have any color in them
despite being 16 or 22px size or using the `-symbolic` suffix, this
needs to be considered an intentional stylistic choice on the part of
the icon theme, and it isn't something that we should monkey with here.

As a bonus, we also reap an efficiency win by simply doing less
unnecessary work most of the time.

If a developer wants to do this masking anyway, they are still free to
set `mask: true` in their code and then it will happen on an opt-in
basis.
Related: bug 473001, bug 471803, bug 469978, bug 451538
FIXED-IN: 6.0

M  +2    -93   src/icon.cpp

https://invent.kde.org/frameworks/kirigami/-/commit/bdb322527fbc910ce7124a45dc43dfaa0fad1522