Bug 465344 - Full line highlight is disabled after selecting two items
Summary: Full line highlight is disabled after selecting two items
Status: CONFIRMED
Alias: None
Product: dolphin
Classification: Applications
Component: view-engine: details mode (show other bugs)
Version: 22.12.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-05 22:10 UTC by medin
Modified: 2023-02-12 05:22 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Full line highlight is disabled after selecting two items (1.80 MB, video/mp4)
2023-02-05 22:10 UTC, medin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description medin 2023-02-05 22:10:43 UTC
Created attachment 155986 [details]
Full line highlight is disabled after selecting two items

After selecting two items, if you pass the mouse over a line its color is not changed until the pointer get inside the file/folder name region, the same behavior exists in selection mode (activated with space key), see attached video for more info.

Operating System: Manjaro Linux
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Kernel Version: 6.1.9-1-MANJARO (64-bit)
Graphics Platform: X11
Comment 1 Felix Ernst 2023-02-07 17:10:33 UTC
I know this might seem weird at first, but this is intentional. You see, the highlight is meant to signify what your next click on that area will interact with. When less than two items are selected, the highlight is there because a click in that row will act on the item in that row. However, when two or more items are selected, there won't be a highlight, because the next click on the row will clear the selection instead of acting on the item.

I'd have to dig up all the details, but one of the reasons we implemented this behaviour was to give users an easy way to clear their selection if they do want to do that.

I personally would want the highlight to never appear if any item is selected at all, but this wasn't done yet because Dolphin currently sometimes highlights singular files "by itself" when navigating through the file system. See https://bugs.kde.org/show_bug.cgi?id=424723 for details.
Comment 2 Nate Graham 2023-02-07 17:39:54 UTC
Hmm... I can appreciate the subtleties of that behavior when using single-click outside of selection mode but that's not what's happening here. This happens even in selection mode where a click will select the list item under the cursor. So at least for that use case, the intentional behavior is triggering inappropriately.
Comment 3 Felix Ernst 2023-02-07 19:57:55 UTC
(In reply to Nate Graham from comment #2)
> Hmm... I can appreciate the subtleties of that behavior when using
> single-click outside of selection mode but that's not what's happening here.
> This happens even in selection mode where a click will select the list item
> under the cursor. So at least for that use case, the intentional behavior is
> triggering inappropriately.

I agree that the full row highlight should be showing up in selection mode.
Comment 4 Nate Graham 2023-02-07 20:03:19 UTC
It should also show up if you have the Ctrl or Shift modifier key held down, such that clicking will in fact grow the selection rather than unselecting everything.
Comment 5 medin 2023-02-07 21:25:09 UTC
(In reply to Felix Ernst from comment #1)
> I know this might seem weird at first, but this is intentional. You see, the
> highlight is meant to signify what your next click on that area will
> interact with. When less than two items are selected, the highlight is there
> because a click in that row will act on the item in that row. However, when
> two or more items are selected, there won't be a highlight, because the next
> click on the row will clear the selection instead of acting on the item.
> 

Sorry but your argument is not convincing at all, if I want to deselect my selected items I simply release ctrl key and click anywhere.


> I personally would want the highlight to never appear if any item is
> selected at all

Line Highlighting is a necessary way to make easy and fast selection instead of following that tiny mouse pointer and verify which one is going to be selected.
Comment 6 Felix Ernst 2023-02-10 15:12:03 UTC
(In reply to Nate Graham from comment #4)
> It should also show up if you have the Ctrl or Shift modifier key held down,
> such that clicking will in fact grow the selection rather than unselecting
> everything.

Makes sense to me.
(In reply to medin from comment #5)
> Sorry but your argument is not convincing at all, if I want to deselect my
> selected items I simply release ctrl key and click anywhere.

Not sure if I was able to communicate what I mean. When you are about to "click anywhere" to deselect items, you would be confused if a file was highlighted. You would think that your next click would act on that file instead of deselecting everything and not acting on that file. For that reason the highlight should only show up if your next click will interact with that file.

> > I personally would want the highlight to never appear if any item is
> > selected at all
> 
> Line Highlighting is a necessary way to make easy and fast selection instead
> of following that tiny mouse pointer and verify which one is going to be
> selected.

Right. As Nate said: The highlight should show up while you are for example pressing Ctrl to select additional items.
Comment 7 Serg Podtynnyi 2023-02-12 05:22:12 UTC
I just found the bug, when you have selected multiple items via shift + mouse and after you add some items with ctrl + mouse (toggle and untoggle) the shift + mouse selection stopped working for me.