Bug 465300 - Make "Last Read" marker behave better
Summary: Make "Last Read" marker behave better
Status: RESOLVED FIXED
Alias: None
Product: NeoChat
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-05 03:10 UTC by hosxy
Modified: 2023-12-31 17:47 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hosxy 2023-02-05 03:10:42 UTC
SUMMARY

when "last read: xxxx" appears, it will make bubble under it move down,then when it disappears,the buuble under it will move up.
And it appear and disapear frequently,the bubble undet it also move down and up frequently in timeline. Because of it,my eyes become so tired.

So, pleasea limit the frequency of the read marker appearing and disappearing, and please add an option to disable it completely, I think many prople like me don't care read marker, and it is very annoying when reading message in timeline

SOFTWARE/OS VERSIONS
Windows:  windows 10 22H2
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Comment 1 kinghat 2023-02-10 17:41:28 UTC
i think the way discord does this is the best. show a static last read marker for the duration while youre viewing the room. only reset it after you've migrated to a different room. simplifies the logic and nobody is ever complaining that their reading spot is gone or that its too annoying.

i also think that if we are not enabling certain timeline events, those should not be taken into account anywhere else in the neochat interface, including the last read. thats probably another issue that should be opened but in regards to the last read marker, you will see it pop up when navigating to a room but there were no new messages. just hidden timeline events.
Comment 2 Tobias Fella 2023-02-10 18:03:50 UTC
We can figure something out for how to improve the last read marker, but i will not create or accept a patch adding an option to disable it.
Comment 3 James Graham 2023-02-12 15:35:53 UTC
Yeah we should be able to make it so that new messages reset the timer that removes the read marker so that it just stays where it is for a succession of messages in a short time period but I agree we shouldn't be trying to disable it.
Comment 4 kinghat 2023-02-12 16:10:36 UTC
a case for never removing the last read marker is because its based on window activation. if i open my laptop with neochat window active, slide to its virtual desktop where its active or i mistakenly click/atl + tab through windows onto neochat it will start the timer of the last read even if i have no intention of catching up on the history at that moment. now ive lost my place.

you already keep the last read marker static when its out of view and you have to click the "jump to first unread message" until you get caught up, then its removed. thats better but i still think you shouldnt remove it until you've made the decision to navigate away from the room.

also just having things appearing and disappearing all the time is jarring. same with the placement/style of typing indicator(which should be optional). imo its a bad ux. as someone who enjoys knowing my place in history, hopefully i can layout objective points as to why.
Comment 5 Bug Janitor Service 2023-12-31 15:18:42 UTC
A possibly relevant merge request was started @ https://invent.kde.org/network/neochat/-/merge_requests/1498
Comment 6 James Graham 2023-12-31 17:47:30 UTC
Git commit e807ad990841e74900304697c7267926995ea203 by James Graham.
Committed on 31/12/2023 at 18:47.
Pushed by nvrwhere into branch 'master'.

Improve the unread marker behaviour

The fixes include:
- improving the timer to make it more reliable
- making sure a read marker is added when changin rooms, this is needed when the messages have already been loaded.
- increase the default timer to 10s to avoid the read marker disappearing and being re-added when a message arrive in quick succession. 

M  +6    -0    src/models/messageeventmodel.cpp
M  +12   -11   src/qml/TimelineView.qml

https://invent.kde.org/network/neochat/-/commit/e807ad990841e74900304697c7267926995ea203