Bug 465094 - Falkon should search for dictionaries in `QTWEBENGINE_DICTIONARIES_PATH`
Summary: Falkon should search for dictionaries in `QTWEBENGINE_DICTIONARIES_PATH`
Status: RESOLVED FIXED
Alias: None
Product: Falkon
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: David Rosca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-31 22:17 UTC by Soren Stoutner
Modified: 2023-02-04 15:06 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/network/falkon/commit/2b9e94a97dfa8286f143947f3ba2ed9875d699c3
Version Fixed In: 23.04.0
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Soren Stoutner 2023-01-31 22:17:07 UTC 
This should mirror the logic in Qt WebEngine as can see seen on line 235 of https://sources.debian.org/src/qtwebengine-opensource-src/5.15.12%2Bdfsg-2/src/core/web_engine_library_info.cpp/.

Debian has recently added .bdic dictionaries and populates the `QTWEBENGINE_DICTIONARIES_PATH` to point to /usr/share/hunspell-bdic.

There is more information at https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020387 and https://salsa.debian.org/qt-kde-team/qt/qtwebengine/-/merge_requests/12.
Comment 1 Bug Janitor Service 2023-02-02 23:59:29 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/falkon/-/merge_requests/45
Comment 2 Juraj 2023-02-04 15:06:00 UTC 
Git commit 2b9e94a97dfa8286f143947f3ba2ed9875d699c3 by Juraj Oravec.
Committed on 04/02/2023 at 14:55.
Pushed by jurajo into branch 'master'.

Look for dictionaries at QTWEBENGINE_DICTIONARIES_PATH env var
FIXED-IN: 23.04.0

Signed-off-by: Juraj Oravec <jurajoravec@mailo.com>

M  +11   -6    src/lib/preferences/preferences.cpp

https://invent.kde.org/network/falkon/commit/2b9e94a97dfa8286f143947f3ba2ed9875d699c3