Bug 464974 - Edge Crop Effect: Automatic center crop
Summary: Edge Crop Effect: Automatic center crop
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Video Effects & Transitions (other bugs)
Version First Reported In: 22.12.1
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-29 08:01 UTC by Jay
Modified: 2024-01-16 20:46 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jay 2023-01-29 08:01:33 UTC
SUMMARY
when working with files that are not the projects aspect ratio, (eg, project profile ratio 900x900 and inserting a 1920x1080 file. it will have to be cropped to remove empty black space)

in the  "edge crop" effect, you have the TOGGLE feature "automatic center crop" to do a 'scale to fill' and underneath that toggle, you have "center balance" slide bar to adjust the focus area  - this does not not pan / cover the whole image, from 0-100 pans only in one direct from the center. usually up from center if its a vertical pan, left if its horizontal. missing down or right from 0 being the very center.

my current workaround:  untick the auto centre crop and manually crop the sides until i get the scale to fill, and often after render find black screen lines on the very edges that i missed. having the auto crop feature would save me so much time and effort.

all my work is focused on slideshows and i deal with at least 200 images and short videos / gifs. this is my most used effect but it isnt a finished effect.



STEPS TO REPRODUCE
1. new project profile, different from sample file frame aspect ratio. eg 900x900 Square
2. insert the desired sample clip / image. different to project profile eg 1920x1080 rectangle
3. "edge crop" effect - tick the "automatic center crop" TOGGLE.  
4. in the "center balance" slide bar, adjust it to try and pan down the crop from center or right from center

OBSERVED RESULT
only pans / moves focus up or left. 

EXPECTED RESULT
to pan fully up/down on vertical outscaled clips. and left/right on horizontal outscaled clips

SOFTWARE/OS VERSIONS
Windows: 10
Comment 1 Jean-Baptiste Mardelle 2024-01-12 15:10:31 UTC
Git commit d9683c991e1342891a3007e79c73d721d54eabeb by Jean-Baptiste Mardelle.
Committed on 12/01/2024 at 16:10.
Pushed by mardelle into branch 'release/24.02'.

Fix center crop adjust not covering full image

M  +1    -1    data/effects/crop.xml

https://invent.kde.org/multimedia/kdenlive/-/commit/d9683c991e1342891a3007e79c73d721d54eabeb
Comment 2 Jean-Baptiste Mardelle 2024-01-16 20:46:45 UTC
Git commit 89350b5f3254a7a614a6d7e95d53d5683af9c3cc by Jean-Baptiste Mardelle.
Committed on 16/01/2024 at 21:40.
Pushed by mardelle into branch 'release/23.08'.

Fix center crop adjust not covering full image

M  +1    -1    data/effects/crop.xml

https://invent.kde.org/multimedia/kdenlive/-/commit/89350b5f3254a7a614a6d7e95d53d5683af9c3cc