Bug 464971 - Kickoff gets extra top/bottom paddings in a vertical panel
Summary: Kickoff gets extra top/bottom paddings in a vertical panel
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) widget (other bugs)
Version First Reported In: 5.26.90
Platform: Arch Linux Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2023-01-29 04:29 UTC by Jin Liu
Modified: 2023-03-08 14:47 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.27
Sentry Crash Report:


Attachments
Vertical panel (467.42 KB, image/jpeg)
2023-01-29 04:29 UTC, Jin Liu
Details
Horizontal panel (467.68 KB, image/jpeg)
2023-01-29 04:31 UTC, Jin Liu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jin Liu 2023-01-29 04:29:55 UTC
Created attachment 155751 [details]
Vertical panel

SUMMARY
In a vertical panel, the Kickoff icon now has more top/bottom paddings, compared to 5.26. This makes spacings uneven between Kickoff and other Task Manager icons. (1st attachment)
Spacings are even in a horizontal panel. (2nd attachment)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8

ADDITIONAL INFORMATION
Comment 1 Jin Liu 2023-01-29 04:31:19 UTC
Created attachment 155752 [details]
Horizontal panel
Comment 2 Bug Janitor Service 2023-02-06 03:19:08 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1375
Comment 3 Jin Liu 2023-02-06 16:04:55 UTC
Git commit 1988f0756ec9b61d6eff6eae14c1023502d7f701 by Jin Liu.
Committed on 06/02/2023 at 02:56.
Pushed by ngraham into branch 'master'.

applets/kickoff: fix: height larger than previous version in vertical panel

In a vertical panel, the Kickoff icon is taller than 5.26, making the icon
spacing uneven with task manager icons.

This regression was introduced by commit
https://invent.kde.org/plasma/plasma-desktop/-/commit/f3cc3ea33f59f627519956225a654cc7f73476e2

M  +1    -1    applets/kickoff/package/contents/ui/Kickoff.qml

https://invent.kde.org/plasma/plasma-desktop/commit/1988f0756ec9b61d6eff6eae14c1023502d7f701
Comment 4 Nate Graham 2023-02-06 16:05:15 UTC
Git commit 365b04724eb049b19726b584aff55397e9ec560b by Nate Graham, on behalf of Jin Liu.
Committed on 06/02/2023 at 16:05.
Pushed by ngraham into branch 'cherry-pick-1988f075'.

applets/kickoff: fix: height larger than previous version in vertical panel

In a vertical panel, the Kickoff icon is taller than 5.26, making the icon
spacing uneven with task manager icons.

This regression was introduced by commit
https://invent.kde.org/plasma/plasma-desktop/-/commit/f3cc3ea33f59f627519956225a654cc7f73476e2


(cherry picked from commit 1988f0756ec9b61d6eff6eae14c1023502d7f701)

M  +1    -1    applets/kickoff/package/contents/ui/Kickoff.qml

https://invent.kde.org/plasma/plasma-desktop/commit/365b04724eb049b19726b584aff55397e9ec560b