Bug 464936 - SPICE syntax-highlighting not correct
Summary: SPICE syntax-highlighting not correct
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-28 10:49 UTC by kliurka
Modified: 2023-02-04 09:48 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
spice model file (1.74 KB, text/plain)
2023-01-28 10:49 UTC, kliurka
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kliurka 2023-01-28 10:49:07 UTC
Created attachment 155724 [details]
spice model file

In brackets  "*"  symbol need interpret as multiplication sign, but not as comment
Comment 1 kliurka 2023-01-28 10:56:48 UTC
In bracket "*" multiplication sign interpreted as comments
Comment 2 Jonathan Poelen 2023-02-01 00:11:19 UTC
I looked for a document that explains the syntax, but it is not clear to me:

Should comments with * always start at the beginning of the line? Can there be spaces before?
Can expressions between braces be on more than one line? If so, does a * at the beginning of the line indicate a multiplication or a comment?
I saw that a comment in some Spice dialect can start with a semicolon. Is this true? I see that you use them in your file.
Comment 3 kliurka 2023-02-01 14:03:46 UTC
"Any line that begins with an * is a comment" - is from: https://www.seas.upenn.edu/~jan/spice/PSpice_ReferenceguideOrCAD.pdf
I think "gedit" text editor works properly. There, the comment is interpreted only if the line begins with "*"
Comment 4 Bug Janitor Service 2023-02-03 00:13:26 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/445
Comment 5 Christoph Cullmann 2023-02-04 09:48:25 UTC
Git commit 3107f0e1dd9b78692d8d41486877c77140212490 by Christoph Cullmann, on behalf of Jonathan Poelen.
Committed on 04/02/2023 at 09:44.
Pushed by cullmann into branch 'master'.

Spice: fix comments and various improvements

A  +48   -0    autotests/folding/highlight.sp.fold
A  +55   -0    autotests/html/highlight.sp.dark.html
A  +55   -0    autotests/html/highlight.sp.html
A  +48   -0    autotests/input/highlight.sp
A  +48   -0    autotests/reference/highlight.sp.ref
M  +242  -20   data/syntax/spice.xml

https://invent.kde.org/frameworks/syntax-highlighting/commit/3107f0e1dd9b78692d8d41486877c77140212490