Bug 464860 - [p7zip plugin] Risk of data loss due to notification indicating successful compression to 7zip format when in fact the compression failed
Summary: [p7zip plugin] Risk of data loss due to notification indicating successful co...
Status: CONFIRMED
Alias: None
Product: ark
Classification: Applications
Component: plugins (show other bugs)
Version: 22.12.1
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Elvis Angelaccio
URL:
Keywords:
: 436915 (view as bug list)
Depends on:
Blocks:
 
Reported: 2023-01-26 17:34 UTC by Patrick Silva
Modified: 2024-06-08 16:49 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2023-01-26 17:34:50 UTC
SUMMARY
I compressed a folder containing 107 files (4.8 GiB in total) to a password-protected 7zip archive.
The notification from Ark said 'Compressing 107 files (Finished)' but the integrity test ran with Ark failed.
Then I tried to extract the created 7zip archive and the extraction failed, confirming the compression failure.
This false 'Compressing 107 files (Finished)'  could have resulted in a data loss if I had deleted the compressed folder
before checking the integrity of the created 7zip archive.


STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT
false 'Compressing 107 files (Finished)' can lead to data loss

EXPECTED RESULT
never say 'Compressing 107 files (Finished)' when a compression fails. 
The notification must inform eventual failures instead.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Graphics Platform: Wayland
Comment 1 Patrick Silva 2023-01-27 03:35:34 UTC
Compression to 7zip fails randomly only when I use the context menu of Dolphin. If I open Ark , drag the folder and drop it on Ark, the compression to 7zip occurs as expected. Here is the log after a unsuccessful compression via context menu of Dolphin:

ark.kerfuffle: Opening add dialog
ark.kerfuffle: CreateDialog returned URL: "file:///home/stalker/Área de trabalho/Videos.7z"
ark.kerfuffle: CreateDialog returned mime: "application/x-7z-compressed"
ark.kerfuffle: Starting job
ark.kerfuffle: Setting GlobalWorkDir to  "/home/stalker/Área de trabalho"
ark.kerfuffle: Going to create archive "/home/stalker/Área de trabalho/Videos.7z"
ark.kerfuffle: Checking plugin "kerfuffle_cli7z"
ark.kerfuffle: Created read-only interface for "/home/stalker/Área de trabalho/Videos.7z"
ark.kerfuffle: Created read-write interface for "/home/stalker/Área de trabalho/Videos.7z"
ark.cli7z: Loaded cli_7z plugin
ark.cli7z: Setting up parameters...
ark.cli7z: Checking 7z variant...
ark.cli7z: Detected p7zip variant.
ark.kerfuffle: Successfully loaded plugin "kerfuffle_cli7z"
ark.kerfuffle: Created archive instance
ark.kerfuffle: Created job instance
ark.kerfuffle: Going to add files QVector(Entry(QVariant(QString, "/home/stalker/Área de trabalho/Videos")) )  with options (encryption hint: true, compression method: "LZMA2", global work dir: "/home/stalker/Área de trabalho", compression level: 5, volume size: 0)
ark.kerfuffle: Created job instance
ark.kerfuffle: GlobalWorkDir is set, changing dir to  "/home/stalker/Área de trabalho"
ark.kerfuffle: Going to add 108 entries, counted in 0 ms
ark.kerfuffle: Adding 1 file(s) to destination: ""
ark.kerfuffle: Executing "/usr/bin/7z" ("a", "-l", "-pmypassword", "-mhe=on", "-mx=5", "-m0=LZMA2", "/home/stalker/Área de trabalho/Videos.7z", "Videos") within directory "/home/stalker/Área de trabalho"
ark.kerfuffle: Process finished, exitcode: 0 exitstatus: QProcess::NormalExit
ark.kerfuffle: Executing "/usr/bin/7z" ("l", "-slt", "-pmypassword", "/home/stalker/Área de trabalho/Videos.7z") within directory "/home/stalker/Área de trabalho"
ark.cli7z: p7zip version "17.04" detected
ark.cli7z: Archive name:  "/home/stalker/Área de trabalho/Videos.7z"
ark.cli7z: Archive type:  "7z"
ark.kerfuffle: Process finished, exitcode: 0 exitstatus: QProcess::NormalExit
ark.kerfuffle: Job finished, result: true , time: 1219146 ms
ark.kerfuffle: job finished
kf.coreaddons: Expected a KPluginFactory, got a KIOPluginForMetaData
ark.main: Trying to open QUrl("file:///home/stalker/Área de trabalho/Videos.7z")
ark.part: Attempting to open archive "/home/stalker/Área de trabalho/Videos.7z"
ark.kerfuffle: Going to create archive "/home/stalker/Área de trabalho/Videos.7z"
ark.kerfuffle: Checking plugin "kerfuffle_cli7z"
ark.kerfuffle: Created read-only interface for "/home/stalker/Área de trabalho/Videos.7z"
ark.kerfuffle: Created read-write interface for "/home/stalker/Área de trabalho/Videos.7z"
ark.cli7z: Loaded cli_7z plugin
ark.cli7z: Setting up parameters...
ark.cli7z: Checking 7z variant...
ark.cli7z: Detected p7zip variant.
ark.kerfuffle: Successfully loaded plugin "kerfuffle_cli7z"
ark.kerfuffle: Created archive instance
ark.kerfuffle: Created job instance
ark.main: Entering application loop
ark.kerfuffle: Executing "/usr/bin/7z" ("l", "-slt", "/home/stalker/Área de trabalho/Videos.7z") within directory "/home/stalker/Área de trabalho"
ark.cli7z: p7zip version "17.04" detected
ark.cli7z: Archive name:  "/home/stalker/Área de trabalho/Videos.7z"
ark.kerfuffle: Found a password prompt
ark.kerfuffle: Executing password prompt
ark.kerfuffle: Writing "mypassword\n" to the process
ark.cli7z: Archive type:  "7z"
ark.kerfuffle: Process finished, exitcode: 0 exitstatus: QProcess::NormalExit
ark.kerfuffle: Job finished, result: true , time: 7203 ms
ark.part: Showing columns:  (0, 1, 3, 7, 9, 11)
ark.part: Time to count entries and size: 0 ms
ark.kerfuffle: Going to test archive
ark.kerfuffle: Job started
ark.kerfuffle: Executing "/usr/bin/7z" ("t", "-pmypassword", "/home/stalker/Área de trabalho/Videos.7z") within directory "/home/stalker/Área de trabalho"
ark.kerfuffle: Process finished, exitcode: 2 exitstatus: QProcess::NormalExit
ark.kerfuffle: Job finished, result: true , time: 213525 ms
Comment 2 Pedro V 2024-04-29 11:16:14 UTC
Bug #453452 could be related, there's generally a problem with the lack of error handling for issues related to the external 7z executable.

The password passed in the command line is a whole another issue I'd highlight here as I was surprised to see that "-pmypassword" part which can be seen by all users on the host on most setups.

Not really seeing an error message though, or a specific error. Quite a bit of time passed since the report, but do you have any more specific information?
Were the files actually archived in that 7203 ms? I would expect no archive in that time, but then a file not even existing shouldn't take 213525 ms to verify.
Comment 3 Bug Janitor Service 2024-05-14 03:45:22 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Bug Janitor Service 2024-05-29 03:45:38 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!
Comment 5 Elvis Angelaccio 2024-06-08 15:52:25 UTC
Confirmed, there are a bunch of errors from the 7z output that are currently ignored by ark. For instance the following one when trying to compress the firefox profile folder:


>7-Zip [64] 17.05 : Copyright (c) 1999-2021 Igor Pavlov : 2017-08-28
>p7zip Version 17.05 (locale=en_US.UTF-8,Utf16=on,HugeFiles=on,64 bits,16 CPUs x64)
>Scanning the drive:
>ERROR:
>stat error for d0idqhmm.default-default/lock (No such file or directory)

However, I strongly recommend to upgrade to ark 24.05 which can use libarchive to handle the 7z format. Hopefully one day we can drop the p7zip plugin and forget about this parsing madness.
Comment 6 Elvis Angelaccio 2024-06-08 16:49:14 UTC
*** Bug 436915 has been marked as a duplicate of this bug. ***