Bug 464829 - Now impossible to select-multi-line text on scrollable views
Summary: Now impossible to select-multi-line text on scrollable views
Status: RESOLVED FIXED
Alias: None
Product: frameworks-qqc2-desktop-style
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2023-01-25 21:42 UTC by Nate Graham
Modified: 2023-02-01 09:46 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2023-01-25 21:42:24 UTC
Following https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/215 being merged, scrollable views that include selectable labels now scroll up and down when you try to click-and-drag to select multiple lines of text. This can be seen on NeoChat's chat view and Discover's app page, both of which have selectable multi-line text on scrollable views.
Comment 1 Nate Graham 2023-01-25 21:43:55 UTC
In essence, mouse-selectable text now triggers Bug 460052, whereas before https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/215 was merged, it didn't.
Comment 2 ratijas 2023-01-26 20:59:46 UTC
OK, so that wasn't just me glitching out, huh
Comment 3 Marco Martin 2023-02-01 08:25:45 UTC
Same bug in Kirigami.SelectableLabel that plain Label had
Comment 4 Marco Martin 2023-02-01 08:26:02 UTC
has nothing to do with https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/215
Comment 5 Bug Janitor Service 2023-02-01 08:30:29 UTC
A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/949
Comment 6 Marco Martin 2023-02-01 09:10:10 UTC
Git commit de1ae4b302e1e41012211a9826f687e2550c91f0 by Marco Martin.
Committed on 01/02/2023 at 09:09.
Pushed by mart into branch 'master'.

Disable HoverHandler

As https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/215
the hoverhandler needs to be disabled in order to not steal events from
the flickable (and making it flickable with mouse even if in a ScrollView)

When disabled, an HoverHAndler *still* has the behavior on hover
working,
it just disables press events handling which shouldn't accept in the
first place

M  +7    -0    src/controls/SelectableLabel.qml

https://invent.kde.org/frameworks/kirigami/commit/de1ae4b302e1e41012211a9826f687e2550c91f0
Comment 7 Marco Martin 2023-02-01 09:46:44 UTC
Git commit b2a5c8901cb91c42f29a9fb742f31600f19595b1 by Marco Martin.
Committed on 01/02/2023 at 09:46.
Pushed by mart into branch 'kf5'.

Disable HoverHandler

As https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/215
the hoverhandler needs to be disabled in order to not steal events from
the flickable (and making it flickable with mouse even if in a ScrollView)

When disabled, an HoverHAndler *still* has the behavior on hover
working,
it just disables press events handling which shouldn't accept in the
first place

M  +7    -0    src/controls/SelectableLabel.qml

https://invent.kde.org/frameworks/kirigami/commit/b2a5c8901cb91c42f29a9fb742f31600f19595b1