Bug 464810 - Windows should only snap to custom tiling when Shift is pressed, not regular tiles
Summary: Windows should only snap to custom tiling when Shift is pressed, not regular ...
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: Custom Tiling (show other bugs)
Version: 5.26.90
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-25 17:00 UTC by Iyán Méndez Veiga
Modified: 2023-01-27 20:52 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Iyán Méndez Veiga 2023-01-25 17:00:28 UTC
SUMMARY
This is a suggestion to improve the new custom tiling system. When shift is pressed, the custom tiles are highlighted while moving windows. However, if window is dragged too much (until a corner), it will snap to the normal tile (half screen, top corner, etc.), not the custom one. I think, when shift is pressed, regular tiles should be completely ignored.


STEPS TO REPRODUCE
1. Prepare some custom tiles (or use default ones)
2. With shift pressed, drag a window to the left or right border

OBSERVED RESULT
Window snap to the regular half screen tile, even though the custom tile is highlighted.

EXPECTED RESULT
With shift pressed, only custom tiles are used.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Kernel Version: 6.1.8-arch1-1 (64-bit)
Graphics Platform: Wayland
Processors: 8 × 11th Gen Intel® Core™ i5-1135G7 @ 2.40GHz
Memory: 15.4 GiB of RAM
Graphics Processor: Mesa Intel® Xe Graphics
Manufacturer: LENOVO
Product Name: 20XYCTO1WW
System Version: ThinkPad X1 Yoga Gen 6
Comment 1 Nate Graham 2023-01-25 18:13:48 UTC
Agreed.
Comment 2 Bug Janitor Service 2023-01-26 10:06:01 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3496
Comment 3 Vlad Zahorodnii 2023-01-26 10:43:51 UTC
Git commit 81b05bd87ee6ab4ec91f2a13b16d3bbe399dc954 by Vlad Zahorodnii.
Committed on 26/01/2023 at 10:01.
Pushed by vladz into branch 'master'.

Avoid mistriggering quick tiling when using custom tiling

If user has chosen custom tiling, ensure that quick tiling state is
reset.

M  +21   -6    src/window.cpp
M  +1    -0    src/window.h

https://invent.kde.org/plasma/kwin/commit/81b05bd87ee6ab4ec91f2a13b16d3bbe399dc954
Comment 4 Vlad Zahorodnii 2023-01-26 10:44:24 UTC
Git commit 0539c58537755a97987940fb258ada9cd50e42cb by Vlad Zahorodnii.
Committed on 26/01/2023 at 10:44.
Pushed by vladz into branch 'cherry-pick-81b05bd8'.

Avoid mistriggering quick tiling when using custom tiling

If user has chosen custom tiling, ensure that quick tiling state is
reset.


(cherry picked from commit 81b05bd87ee6ab4ec91f2a13b16d3bbe399dc954)

M  +21   -6    src/window.cpp
M  +1    -0    src/window.h

https://invent.kde.org/plasma/kwin/commit/0539c58537755a97987940fb258ada9cd50e42cb
Comment 5 Iyán Méndez Veiga 2023-01-26 13:43:51 UTC
I cannot apply that commit directly to Plasma/5.27 branch. Can you point me what additional commits should I add before to test this?
Comment 6 Vlad Zahorodnii 2023-01-26 15:15:18 UTC
If you can build kwin from source code, just checkout Plasma/5.27

but I guess it fails to apply because of https://invent.kde.org/plasma/kwin/-/commit/e9d46f93231e43b2c8ea3a8408d1031b255268a9 and https://invent.kde.org/plasma/kwin/-/commit/50c81577568da41dfa3621ea3daa0226debad92f
Comment 7 Iyán Méndez Veiga 2023-01-26 20:57:36 UTC
Yep, I confirmed this is fixed for me now.