Bug 464803 - Do not disturb shows expired times
Summary: Do not disturb shows expired times
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.26.5
Platform: unspecified Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-25 15:33 UTC by Nicola Smaniotto
Modified: 2023-05-01 16:43 UTC (History)
2 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/plasma-workspace/commit/ab9576d68fe623f7c1e002460e2bfce2ff14c220
Version Fixed In: 5.27.5

Attachments
Do not disturb inhibited until 11 days ago (27.23 KB, image/png)
2023-01-25 15:33 UTC, Nicola Smaniotto 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Nicola Smaniotto 2023-01-25 15:33:59 UTC 
Created attachment 155633 [details]
Do not disturb inhibited until 11 days ago

SUMMARY
While "Do not disturb" is activated by a program, the previous time is shown even if it already expired.

STEPS TO REPRODUCE
1. Activate "Do not disturb" for a fixed amount of time.
2. Let it expire.
3. Activate "Do not disturb" by inhibiting the notifications from a program (for example QDbusViewer).

OBSERVED RESULT
The applet shows the expired time as well as the software currently inhibiting.

EXPECTED RESULT
Only the program should be shown. A time in the past should be ignored, since it is not really blocking the notifications.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.25.5
KDE Frameworks Version: 5.99.0
Qt Version: 5.15.7
Comment 1 Bug Janitor Service 2023-01-25 16:33:32 UTC 
Thank you for the bug report!

Please note that Plasma 5.25.5 is not supported for much longer by KDE; supported versions are 5.24, and 5.26 or newer.

If at all possible please upgrade to a supported version and verify that the bug is still happening there.

If you're unsure how to do this, contact your distributor about it.
Comment 2 Nicola Smaniotto 2023-01-28 16:07:27 UTC 
I reported for 5.25 because I use gentoo stable.

I was able to reproduce this on arch as well: plasma 5.26.5, frameworks 5.102.0, qt 5.15.8.
Comment 3 Bug Janitor Service 2023-04-28 14:00:26 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2878
Comment 4 Nate Graham 2023-05-01 16:41:24 UTC 
Git commit c4860972511b1160ee2f214b3dd54a7b40a95105 by Nate Graham, on behalf of Nicola Smaniotto.
Committed on 01/05/2023 at 16:41.
Pushed by ngraham into branch 'master'.

applets/notifications: Handle the case of the finish date being in the future
FIXED-IN: 5.27.5

M  +4    -1    applets/notifications/package/contents/ui/FullRepresentation.qml
M  +5    -3    applets/notifications/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/c4860972511b1160ee2f214b3dd54a7b40a95105
Comment 5 Nate Graham 2023-05-01 16:43:00 UTC 
Git commit ab9576d68fe623f7c1e002460e2bfce2ff14c220 by Nate Graham, on behalf of Nicola Smaniotto.
Committed on 01/05/2023 at 16:42.
Pushed by ngraham into branch 'Plasma/5.27'.

applets/notifications: Handle the case of the finish date being in the future
FIXED-IN: 5.27.5


(cherry picked from commit c4860972511b1160ee2f214b3dd54a7b40a95105)

M  +4    -1    applets/notifications/package/contents/ui/FullRepresentation.qml
M  +5    -3    applets/notifications/package/contents/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/commit/ab9576d68fe623f7c1e002460e2bfce2ff14c220