Bug 464755 - Keyboard backlight toggle should restore value when toggling off and on again
Summary: Keyboard backlight toggle should restore value when toggling off and on again
Status: RESOLVED FIXED
Alias: None
Product: Powerdevil
Classification: Plasma
Component: general (show other bugs)
Version: 5.26.5
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Natalie Clarius
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-24 17:47 UTC by Werner Sembach [TUXEDO]
Modified: 2023-08-14 15:53 UTC (History)
3 users (show)

See Also:
Latest Commit: https://invent.kde.org/plasma/powerdevil/-/commit/072c4e1d94cf02b19f52def1681a43c0e99b683d
Version Fixed In: 6.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Werner Sembach [TUXEDO] 2023-01-24 17:47:35 UTC 
Currently hitting a keyboard backlight toggle key (e.g. a fn key) switches they keyboard backlight to 0% from any % other then 0% and to 100% when it was 0% before. The percentage it was befor being switched of is not saved.

This would be way more usefull if one could for example set keyboard backlight brightness to 50% and then use the toggle key to switch between 0 and 50% instead of 0 and 100%
Comment 1 Bug Janitor Service 2023-08-09 22:42:53 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/powerdevil/-/merge_requests/206
Comment 2 Nate Graham 2023-08-14 15:53:17 UTC 
Git commit 072c4e1d94cf02b19f52def1681a43c0e99b683d by Nate Graham, on behalf of Natalie Clarius.
Committed on 14/08/2023 at 17:51.
Pushed by ngraham into branch 'master'.

Restore previous brightness value after toggling keyboard backlight

... provided it was not already zero, instead of always setting to maximum brightness.

FIXED-IN: 6.0

M  +14   -1    daemon/backends/upower/powerdevilupowerbackend.cpp
M  +1    -0    daemon/backends/upower/powerdevilupowerbackend.h
M  +1    -1    daemon/powerdevilbackendinterface.cpp
M  +3    -0    daemon/powerdevilbackendinterface.h
M  +15   -3    daemon/powerdevilbrightnesslogic.cpp
M  +11   -1    daemon/powerdevilbrightnesslogic.h

https://invent.kde.org/plasma/powerdevil/-/commit/072c4e1d94cf02b19f52def1681a43c0e99b683d