Bug 464644 - Regex for GoPro proxy clips (lrv) is worng
Summary: Regex for GoPro proxy clips (lrv) is worng
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: Rendering & Export (show other bugs)
Version: 22.12.1
Platform: unspecified All
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-22 12:37 UTC by Ricardo
Modified: 2023-10-20 21:11 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ricardo 2023-01-22 12:37:36 UTC
SUMMARY
Regex for GoPro proxy clips is wrong. GoPro naming convention is very weird, first clip starts with "GOPR" and following clips starts with "GP". You are searching for:
Prefix clip: GX;GP
Prefix of proxy: GL;GP

you miss "GOPR".

Check this ls output:
GOPR0035.LRV
GOPR0035.MP4
GOPR0035.THM
GP010035.LRV
GP010035.MP4
GP020035.LRV
GP020035.MP4


STEPS TO REPRODUCE
1. Try to add an LRV clip which name starts with GOPR (first clip of a recording) to the project bin.

OBSERVED RESULT
Kdenlive doesn't recognize it as external proxy clip

EXPECTED RESULT
Kdenlive should recognize the LRV as external proxy clip.

SOFTWARE/OS VERSIONS
Linux Debian 11 (bullseye)

ADDITIONAL INFORMATION
All the remaining LRV files starting with "GP" are recognized.
Comment 1 Gabriel Gazzán 2023-07-01 22:12:11 UTC
Hi,
I had to edit the GoPro LRV preset text file to be able to use it with my "Hero 7" camera generated files too.
It's no big deal, but since the data is available online (see below), it'd be great if Kdenlive could incorporate it out of the box.
In particular my camera files use a "GH" prefix.

Here is a list of all file-naming patterns used in GoPro cameras:
https://community.gopro.com/s/article/GoPro-Camera-File-Naming-Convention?language=en_US

Thanks for listening!
Comment 2 Jean-Baptiste Mardelle 2023-07-11 11:17:36 UTC
Git commit 3df9c96b2995becca9b8ad42c08265ff34a2a19c by Jean-Baptiste Mardelle.
Committed on 11/07/2023 at 11:17.
Pushed by mardelle into branch 'master'.

Add GOPR as external proxy option.

M  +1    -1    data/externalproxies.rc

https://invent.kde.org/multimedia/kdenlive/-/commit/3df9c96b2995becca9b8ad42c08265ff34a2a19c
Comment 3 Jean-Baptiste Mardelle 2023-07-11 16:35:54 UTC
Git commit f46975b42b4c8b530e680075a73f2bff1473e047 by Jean-Baptiste Mardelle.
Committed on 11/07/2023 at 16:35.
Pushed by mardelle into branch 'master'.

Add GL/GH as external proxy option.

M  +1    -1    data/externalproxies.rc

https://invent.kde.org/multimedia/kdenlive/-/commit/f46975b42b4c8b530e680075a73f2bff1473e047