Bug 464597 - Preview does not work consistently with grouped tasks
Summary: Preview does not work consistently with grouped tasks
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (other bugs)
Version First Reported In: 5.26.5
Platform: Arch Linux Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: wayland-only
Depends on:
Blocks:
 
Reported: 2023-01-21 16:06 UTC by Patrick Silva
Modified: 2023-01-25 05:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.27
Sentry Crash Report:


Attachments
screenshot (141.12 KB, image/png)
2023-01-21 16:06 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2023-01-21 16:06:17 UTC
Created attachment 155473 [details]
screenshot

STEPS TO REPRODUCE
1. use Wayland
2. open several instances of Konsole, until they are grouped in the task manager
3. open another app
4. repeatedly move the mouse pointer horizontally over the tasks

OBSERVED RESULT
sometimes the previews of the grouped tasks do not work. Please see the attached screenshot.

EXPECTED RESULT
preview should work consistently

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Graphics Platform: Wayland
Comment 1 Fushan Wen 2023-01-24 07:35:30 UTC
Git commit 8767c0f34319f2be3ea8cb4da4bfa18d6004445c by Fushan Wen.
Committed on 24/01/2023 at 07:34.
Pushed by fusionfuture into branch 'master'.

applets/taskmanager: don't unload tooltip when window is invisible

M  +1    -1    applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/commit/8767c0f34319f2be3ea8cb4da4bfa18d6004445c
Comment 2 Fushan Wen 2023-01-24 07:38:07 UTC
Git commit ba01803e033e423313ee3453124721650cbde153 by Fushan Wen.
Committed on 24/01/2023 at 07:38.
Pushed by fusionfuture into branch 'Plasma/5.27'.

applets/taskmanager: don't unload tooltip when window is invisible


(cherry picked from commit 8767c0f34319f2be3ea8cb4da4bfa18d6004445c)

M  +1    -1    applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/commit/ba01803e033e423313ee3453124721650cbde153
Comment 4 Aleix Pol 2023-01-24 14:00:34 UTC
Git commit 67f8d36cf3e0364adc9cbd380ffb1ad4dca5b155 by Aleix Pol Gonzalez, on behalf of Fushan Wen.
Committed on 24/01/2023 at 13:44.
Pushed by fusionfuture into branch 'master'.

Allow to reset fd in `PipeWireSourceItem`

The dtor of the source stream object is called after
Component.onDestruction in QML, so the file descriptor can be closed
after a new PipeWireSourceItem creates, which causes the bug.

M  +16   -1    src/pipewiresourceitem.cpp
M  +2    -1    src/pipewiresourceitem.h

https://invent.kde.org/plasma/kpipewire/commit/67f8d36cf3e0364adc9cbd380ffb1ad4dca5b155
Comment 5 Fushan Wen 2023-01-24 14:11:48 UTC
Git commit e96ff18c4e68ca9de0a6dc1e166b1bcbc764cfc1 by Fushan Wen.
Committed on 24/01/2023 at 14:11.
Pushed by fusionfuture into branch 'Plasma/5.27'.

Allow to reset fd in `PipeWireSourceItem`

The dtor of the source stream object is called after
Component.onDestruction in QML, so the file descriptor can be closed
after a new PipeWireSourceItem creates, which causes the bug.


(cherry picked from commit 67f8d36cf3e0364adc9cbd380ffb1ad4dca5b155)

M  +16   -1    src/pipewiresourceitem.cpp
M  +2    -1    src/pipewiresourceitem.h

https://invent.kde.org/plasma/kpipewire/commit/e96ff18c4e68ca9de0a6dc1e166b1bcbc764cfc1
Comment 6 Fushan Wen 2023-01-25 05:37:28 UTC
Git commit 93fd171a40da1bebce8d0ef70f2f6a272b02a777 by Fushan Wen.
Committed on 25/01/2023 at 04:17.
Pushed by fusionfuture into branch 'master'.

applets/taskmanager: show app icon when pipewire thumbnail is unavailable

M  +2    -0    applets/taskmanager/package/contents/ui/PipeWireThumbnail.qml
M  +25   -3    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://invent.kde.org/plasma/plasma-desktop/commit/93fd171a40da1bebce8d0ef70f2f6a272b02a777
Comment 7 Fushan Wen 2023-01-25 05:37:36 UTC
Git commit 3ba196eddc8c37bc56a799a8189c18a4da550a4c by Fushan Wen.
Committed on 25/01/2023 at 04:17.
Pushed by fusionfuture into branch 'master'.

applets/taskmanager: reload tooltip instance when current task changes

Otherwise before the old instance is unloaded, windows property is
updated and hence a redundant screencasting request will be created.

M  +5    -1    applets/taskmanager/package/contents/ui/Task.qml
M  +3    -1    applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/commit/3ba196eddc8c37bc56a799a8189c18a4da550a4c
Comment 8 Bug Janitor Service 2023-01-25 05:41:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1355
Comment 9 Fushan Wen 2023-01-25 05:47:21 UTC
Git commit ea646e1a4b311e443410081489ce62b83e1d2ae3 by Fushan Wen.
Committed on 25/01/2023 at 05:39.
Pushed by fusionfuture into branch 'Plasma/5.27'.

applets/taskmanager: reload tooltip instance when current task changes

Otherwise before the old instance is unloaded, windows property is
updated and hence a redundant screencasting request will be created.
(cherry picked from commit 3ba196eddc8c37bc56a799a8189c18a4da550a4c)

M  +5    -1    applets/taskmanager/package/contents/ui/Task.qml
M  +3    -1    applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

https://invent.kde.org/plasma/plasma-desktop/commit/ea646e1a4b311e443410081489ce62b83e1d2ae3
Comment 10 Fushan Wen 2023-01-25 05:47:29 UTC
Git commit e96ce1d2f8b10aeb20c6e6f98072adef86c7861e by Fushan Wen.
Committed on 25/01/2023 at 05:40.
Pushed by fusionfuture into branch 'Plasma/5.27'.

applets/taskmanager: show app icon when pipewire thumbnail is unavailable
(cherry picked from commit 93fd171a40da1bebce8d0ef70f2f6a272b02a777)

M  +2    -0    applets/taskmanager/package/contents/ui/PipeWireThumbnail.qml
M  +25   -3    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://invent.kde.org/plasma/plasma-desktop/commit/e96ce1d2f8b10aeb20c6e6f98072adef86c7861e