Bug 464573 - Untranslated parts in the kcm_flatpak module
Summary: Untranslated parts in the kcm_flatpak module
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_flatpak (show other bugs)
Version: 5.26.90
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-20 22:40 UTC by Emir SARI
Modified: 2023-01-26 02:06 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments
screenshot (103.36 KB, image/png)
2023-01-20 22:40 UTC, Emir SARI
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Emir SARI 2023-01-20 22:40:02 UTC
Created attachment 155461 [details]
screenshot

SUMMARY
Some of the newly added Flatpak permissions have untranslated parts, although the strings were available to translate.


STEPS TO REPRODUCE
1. Open the Flatpak Application Settings module

OBSERVED RESULT
Permission details are untranslated.

EXPECTED RESULT
All the interface should have been localized.

Operating System: KDE neon Testing Edition
KDE Plasma Version: 5.26.90
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 5.15.0-58-generic (64-bit)
Graphics Platform: X11
Comment 1 Nate Graham 2023-01-23 22:12:43 UTC
> although the strings were available to translate
That means translators simply haven't gotten to these strings yet. What language is this? Is it Turkish?
Comment 2 Emir SARI 2023-01-24 07:40:07 UTC
(In reply to Nate Graham from comment #1)
> > although the strings were available to translate
> That means translators simply haven't gotten to these strings yet. What
> language is this? Is it Turkish?

Well, I’ve translated them the day they were available. Yes, it’s Turkish.
Comment 3 Nate Graham 2023-01-24 16:33:16 UTC
Oh, I didn't realize you were the translator. :) In that case there must be some issue in the code here preventing the translations from appearing. I'm CCing some people who may be able to help.
Comment 4 Albert Astals Cid 2023-01-24 21:52:35 UTC
Wasn't yesterdays discussion on #kde-devel concluded that 

add_definitions(-DTRANSLATION_DOMAIN="...")

was missing for the C++ code to pick up the translation domain properly?
Comment 5 Nate Graham 2023-01-25 15:37:59 UTC
Ah, I didn't see the result of that conversation. Will fix.
Comment 6 Bug Janitor Service 2023-01-25 15:41:41 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/flatpak-kcm/-/merge_requests/27
Comment 7 Luigi Toscano 2023-01-25 23:24:09 UTC
Git commit 82f22694ccee7fd69e1cbaef80633e8b9d7c8474 by Luigi Toscano, on behalf of Nate Graham.
Committed on 25/01/2023 at 22:49.
Pushed by aacid into branch 'master'.

Specify translation domain
FIXED-IN: 5.27

M  +2    -0    CMakeLists.txt

https://invent.kde.org/plasma/flatpak-kcm/commit/82f22694ccee7fd69e1cbaef80633e8b9d7c8474
Comment 8 Nate Graham 2023-01-26 02:06:01 UTC
Git commit a35b10e2b38e3a5bbb49eeec5a13cc1bc6e87950 by Nate Graham.
Committed on 26/01/2023 at 02:05.
Pushed by ngraham into branch 'Plasma/5.27'.

Specify translation domain
FIXED-IN: 5.27


(cherry picked from commit 82f22694ccee7fd69e1cbaef80633e8b9d7c8474)

M  +2    -0    CMakeLists.txt

https://invent.kde.org/plasma/flatpak-kcm/commit/a35b10e2b38e3a5bbb49eeec5a13cc1bc6e87950