Created attachment 155419 [details] Bug presentation Search result will be inactive for external apps which contain the "X-KDE-ServiceTypes=SystemSettingsExternalApp" value. Last working version is ~5.19.4 (on attached picture) STEPS TO REPRODUCE 1. run system settings 2. type any name of external app 3. reults is empty (on attached picture) I made hotfix workaround, see the attached patch.and second picture
Created attachment 155420 [details] Workaround patch for hot fix Our patch for hotfix --- systemsettings-5.26.5.orig/sidebar/package/contents/ui/CategoriesPage.qml 2023-01-03 19:52:53.000000000 +0100 +++ systemsettings-5.26.5/sidebar/package/contents/ui/CategoriesPage.qml 2023-01-19 08:18:59.554547000 +0100 @@ -144,12 +144,13 @@ leadingPadding: (model.DepthRole > 1 && searchField.text.length > 0) ? (( model.DepthRole - 1 ) * Kirigami.Units.iconSizes.smallMedium) + Kirigami.Units.largeSpacing : 0 hoverEnabled: !model.IsCategoryRole || !mainColumn.searchMode - enabled: model.IsKCMRole || !mainColumn.searchMode + //enabled: model.IsKCMRole && model.isExternalApp || !mainColumn.searchMode + enabled: !model.IsCategoryRole|| !mainColumn.searchMode onClicked: { - if (!model.IsKCMRole && mainColumn.searchMode) { - return; - } + //if (!model.IsKCMRole && mainColumn.searchMode) { + // return; + //} if (model.IsKCMRole || mainColumn.searchMode || systemsettings.activeCategoryRow !== index) { systemsettings.loadModule(categoryView.model.index(index, 0)); Regards
Please consider sending the patch through our gitlab instance (invent.kde.org), I don't think we accept email patches anymore. Here's the repository's link for the system settings app: https://invent.kde.org/plasma/systemsettings
Git commit b855f54af3822b4c38f90ffff318a55e992e801f by Nate Graham, on behalf of Charles K Barcza. Committed on 24/01/2023 at 15:14. Pushed by ngraham into branch 'master'. Make external apps clickable in search results FIXED-IN: 5.27 M +2 -5 sidebar/package/contents/ui/CategoriesPage.qml https://invent.kde.org/plasma/systemsettings/commit/b855f54af3822b4c38f90ffff318a55e992e801f
Git commit 0dc9d9ab8e25f46b4b1f41c59b4bd706ecb1cb3a by Nate Graham, on behalf of Charles K Barcza. Committed on 24/01/2023 at 15:27. Pushed by ngraham into branch 'cherry-pick-b855f54a'. Make external apps clickable in search results FIXED-IN: 5.27 (cherry picked from commit b855f54af3822b4c38f90ffff318a55e992e801f) M +2 -5 sidebar/package/contents/ui/CategoriesPage.qml https://invent.kde.org/plasma/systemsettings/commit/0dc9d9ab8e25f46b4b1f41c59b4bd706ecb1cb3a