Bug 464481 - Cannot download new themes - must do manual install
Summary: Cannot download new themes - must do manual install
Status: CONFIRMED
Alias: None
Product: kpat
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-18 22:18 UTC by Jirka Justra
Modified: 2023-03-08 06:25 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jirka Justra 2023-01-18 22:18:25 UTC
SUMMARY

When a new theme is downloaded, it is not added to list and cannot be selected.
It is shown as downloaded in manager, so perhaps program ignores path in AppData where new themes goes?
Once files are  manualy copied from AppData/Local/kpat/themes into Program files/kpat/bin/data/kpat/themes/ folder it works.
Works fine in linux.

version 23.03.70 (nightly build, installed from kpat-master-1187-windows-gcc-x86_64.exe)

STEPS TO REPRODUCE
1. Open 'Change appearance' dialog
2. Download new theme
3. Try to find it in list

OBSERVED RESULT
After installation, downloaded theme is not in list to be selected.

EXPECTED RESULT
Getting my hands on that shiny new interface decoration.

SOFTWARE/OS VERSIONS
Windows: 10 Home - 64bit

ADDITIONAL INFORMATION
none
Comment 1 Ron Nascimento 2023-01-19 11:07:06 UTC
I was able to reproduce the problem following the actions. It seems to download the add-on and acknowledge it, but it does not show up in the list of available themes/skins.

Looking in `~/.local/share/kpat` the directory is empty, sounds similar to the Konsole issue with creating new profiles. Nothing obvious in `~/.config/kpatrc` either. However the card decks seem to be placed in: `~/.local/share/carddecks/` . I downloaded the "Paris Dark" and it was placed in `~/.local/share/carddecks/svg-gm-paris-dark` with 3 files:

1. index.desktop
2. parisdark.svg
3. queen_hear.png

It seems that the index.desktop is similar to the packagers installed card themes in format. Perhaps its not looking for themes in `~/.local/share/carddecks/`.
Comment 2 Ron Nascimento 2023-01-19 11:11:31 UTC
**POSSIBLE** Work around:

Continuing research, I decided to mimic the naming of the packagers pre-installed themes:  themename.ext for all 3 files and place them in `~/.local/share/kpat` like this:

```
 ronaldo  ~  $  cd .local/share/kpat/
 ronaldo  kpat  $  ls -la
total 1328
drwxr-xr-x 1 ronaldo ronaldo      88 Jan 19 06:08 .
drwxr-xr-x 1 ronaldo ronaldo    1110 Jan 19 06:08 ..
-rw-r--r-- 1 ronaldo ronaldo    1227 Jan 19 06:08 parisdark.desktop
-rw-r--r-- 1 ronaldo ronaldo   16261 Jan 19 06:08 parisdark.png
-rw-r--r-- 1 ronaldo ronaldo 1337916 Jan 19 06:08 parisdark.svgz
 ronaldo  kpat  $  
```

Then I opened up kpat and was able to select and use the theme.
Comment 3 Ron Nascimento 2023-01-19 11:13:05 UTC
Forgot: 

Kpat: 22.12.1

Operating System: Arch Linux
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Kernel Version: 6.1.6-arch1-3 (64-bit)
Graphics Platform: Wayland
Processors: 16 × AMD Ryzen 7 7700X 8-Core Processor
Memory: 30.5 GiB of RAM
Graphics Processor: AMD Radeon Graphics
Manufacturer: ASUS
Comment 4 Ron Nascimento 2023-01-19 11:44:45 UTC
Looking at source code: 

1. https://invent.kde.org/games/kpat/-/blob/master/src/renderer.cpp#L67 - shows where it looks for themes
2. https://invent.kde.org/games/kpat/-/blob/master/src/libkcardgame/kcardtheme.cpp#L58 - appears to be looking in `~/.local/share/carddecks` but need to read further...
Comment 5 Ian Wadham 2023-01-19 20:20:35 UTC
I seem to remember that the card decks reside in a library. KPat is not the only card game…

See https://invent.kde.org/games/libkdegames/-/blob/master/src/carddecks/README

> On 19 Jan 2023, at 10:44 pm, Ron Nascimento <bugzilla_noreply@kde.org> wrote:
> 
> https://bugs.kde.org/show_bug.cgi?id=464481
> 
> --- Comment #4 from Ron Nascimento <sgtnasty@gmail.com> ---
> Looking at source code: 
> 
> 1. https://invent.kde.org/games/kpat/-/blob/master/src/renderer.cpp#L67 - shows
> where it looks for themes
> 2.
> https://invent.kde.org/games/kpat/-/blob/master/src/libkcardgame/kcardtheme.cpp#L58
> - appears to be looking in `~/.local/share/carddecks` but need to read
> further...
> 
> -- 
> You are receiving this mail because:
> You are on the CC list for the bug.
Comment 6 Stephan Kulow 2023-03-08 06:25:40 UTC
I'm not really sure where to start here, but I set this to CONFIRMED as at least someone reproduced it