Bug 464429 - Kirigami ScrollablePage has empty space above content when refreshing
Summary: Kirigami ScrollablePage has empty space above content when refreshing
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: Master
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-17 21:03 UTC by Connor Carney
Modified: 2024-01-13 13:10 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
qml to reproduce bug with qmlscene (373 bytes, text/x-qml)
2023-01-17 21:03 UTC, Connor Carney
Details
gammaray showing busy indicator positioned offscreen (128.45 KB, image/png)
2023-01-17 22:16 UTC, Connor Carney
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Connor Carney 2023-01-17 21:03:35 UTC
Created attachment 155392 [details]
qml to reproduce bug with qmlscene

SUMMARY

When ScrollablePage has refreshing: true (see attached qml), space is reserved at the top of the page for the busy indicator, but the busy indicator isn't shown leaving a blank space.

GammaRay shows that the busy indicator is positioned off the top of the screen and scrolls farther off the top of the screen as the list is scrolled down.

The bug in it's current state bisects at commit 497330c5 , but backing out that commit still leaves an issue where the indicator scrolls up with the content, but the reserved space doesn't. 

STEPS TO REPRODUCE
1. run attached qml file with qmlscene

OBSERVED RESULT
blank space at the top of the page

EXPECTED RESULT
busy indicator at the top of the page

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 22.10 w/ KDE from source
KDE Plasma Version: master (5.26.80)
KDE Frameworks Version: master (5.102.0)
Qt Version: 5.15.6 (from Kubuntu)
Comment 1 Connor Carney 2023-01-17 22:16:39 UTC
Created attachment 155393 [details]
gammaray showing busy indicator positioned offscreen
Comment 2 Thiago Sueto 2023-02-01 19:38:16 UTC
Reproducible with Kirigami 5.102.
Comment 3 ratijas 2023-02-01 22:16:05 UTC
In the ScrollablePage -> scrollView, that anchors.topMargin probably should be a topPadding instead. I played with it for few minutes, but the whole feature seems to be broken; likely because there were no users to test it properly. Even if it would make it into KF6, it would have to rewritten almost from scratch: that layouting code, hardcoded style parts (ConicalGradient?) don't make much sense to me.
Comment 4 Connor Carney 2023-02-01 23:42:29 UTC
It was tested enough for the breakage to be noted on the relevant merge request (https://invent.kde.org/frameworks/kirigami/-/merge_requests/732#note_528670).
Comment 5 Connor Carney 2024-01-13 13:10:15 UTC
Fixed with merge of !1404