Bug 464424 - Kate and KWrite freeze when opening this one file
Summary: Kate and KWrite freeze when opening this one file
Status: VERIFIED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2023-01-17 18:59 UTC by Nate Graham
Modified: 2023-01-23 19:53 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
File that causes the freeze (377.75 KB, text/x-log)
2023-01-17 18:59 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2023-01-17 18:59:34 UTC
Created attachment 155390 [details]
File that causes the freeze

Everything KDE from git master. File that causes the freeze is attached. This is 100% reproducible with both apps.

Gedit manages to open the file without freezing, but does complain about invalid encodings. Perhaps a clue.
Comment 1 Justin Zobel 2023-01-18 02:47:04 UTC
Can confirm here as well.
Comment 2 Paul Worrall 2023-01-18 13:11:13 UTC
Patience guys - it only takes 12 minutes to un-freeze 😉

During the freeze it is using a constant 50% load of my two-CPU system.
Comment 3 Paul Worrall 2023-01-18 13:32:09 UTC
It opens instantly (no freeze) on Kate version 22.12.1
Comment 4 Waqar Ahmed 2023-01-18 14:14:25 UTC
This seems to be due to the recently added Log file syntax file.

https://invent.kde.org/frameworks/syntax-highlighting/-/merge_requests/415
Comment 5 Christoph Cullmann 2023-01-22 16:19:47 UTC
Git commit 5017c69a44ea29d6594d3b022f127a4b86be4950 by Christoph Cullmann, on behalf of jonathan poelen.
Committed on 22/01/2023 at 16:19.
Pushed by cullmann into branch 'master'.

Log: fix slow search regex ; add Critical section ; some improvement in Log File (advanced)

M  +1    -1    autotests/folding/highlight.log-advanced.fold
M  +11   -11   autotests/html/highlight.log-advanced.dark.html
M  +11   -11   autotests/html/highlight.log-advanced.html
M  +1    -1    autotests/input/highlight.log-advanced
M  +11   -11   autotests/reference/highlight.log-advanced.ref
M  +207  -40   data/syntax/logfile-advanced.xml
M  +11   -6    data/syntax/logfile.xml

https://invent.kde.org/frameworks/syntax-highlighting/commit/5017c69a44ea29d6594d3b022f127a4b86be4950
Comment 6 Christoph Cullmann 2023-01-22 19:34:49 UTC
Git commit 71c5ea39ee8dac88f74650467b45933be7baa294 by Christoph Cullmann, on behalf of jonathan poelen.
Committed on 22/01/2023 at 19:34.
Pushed by cullmann into branch 'kf5'.

Log: fix slow search regex ; add Critical section ; some improvement in Log File (advanced)


(cherry picked from commit 5017c69a44ea29d6594d3b022f127a4b86be4950)

M  +1    -1    autotests/folding/highlight.log-advanced.fold
M  +11   -11   autotests/html/highlight.log-advanced.dark.html
M  +11   -11   autotests/html/highlight.log-advanced.html
M  +1    -1    autotests/input/highlight.log-advanced
M  +11   -11   autotests/reference/highlight.log-advanced.ref
M  +207  -40   data/syntax/logfile-advanced.xml
M  +11   -6    data/syntax/logfile.xml

https://invent.kde.org/frameworks/syntax-highlighting/commit/71c5ea39ee8dac88f74650467b45933be7baa294
Comment 7 Nate Graham 2023-01-23 19:53:18 UTC
All better now. Thanks so much!