Bug 464388 - No refresh button in header when there are posts in the list
Summary: No refresh button in header when there are posts in the list
Status: RESOLVED WORKSFORME
Alias: None
Product: Alligator
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Android Android 13.x
: NOR normal
Target Milestone: ---
Assignee: Tobias Fella
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-16 21:38 UTC by Jack Hill
Modified: 2023-03-06 20:26 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2023-01-16 21:38:25 UTC
SUMMARY
The Refresh button in the header disappears when there are posts in the list. There's no button to replace it, so why bother hiding it?

STEPS TO REPRODUCE
1. Read all posts
2. Restart the app
3. Go into the Unread tab
4. Click the Refresh button in the top right

OBSERVED RESULT
When new posts are added, the refresh button disappears.

EXPECTED RESULT
Keep the Refresh button, unless there's a new button with higher priority that should take its place.

SOFTWARE/OS VERSIONS

ADDITIONAL INFORMATION
Comment 1 Jack Hill 2023-03-06 20:11:58 UTC
Just to clarify, was this supposed to be marked as intentional? Because I can see in the code that the refresh button has `visible: !Kirigami.Settings.isMobile || entryList.count === 0`, so I don't see how it could be marked as Works For Me.

I don't mind if the button disappears, I just (1) don't see why it should when there's nothing there to replace it, and (2) find the scroll to refresh quite awkward. I find that I have to move my finger quite a long distance compared to other apps with scroll-to-refresh, hence why I prefer to tap the refresh button.
Comment 2 Tobias Fella 2023-03-06 20:26:44 UTC
I've marked it as WORKSFORME since it button is always visible for me. The code does indeed say something else, I'll remove that