Created attachment 155266 [details] Outline test document Hello, I'm having an issue right now on 8e8c855 where stroke effects (and other layer effects, as I've found out) cannot be saved if nothing else in the image has been changed, sometimes. I open the file, change the stroke width or color, ctrl+s or file>save, then close and reopen the file to find my changes have not been saved. For some reason this problem is reasonably hard to recreate and I have not been able to reproduce it from a fresh document. I've attached a document with the problem that I can reliable reproduce it on. To reproduce: 1. Open the document, right click 'Group 10' and choose 'Layer Style...' 2. Under 'stroke', set the color to something else, like white. 3. Click 'okay', then 'okay' again. Observe the outline color has changed. 4. ctrl+s or file > save. Notice the * goes away next to the document name. 5. Close the document, and reopen under 'recent documents' 6. Stroke color is the old color I've experimented with other layer styles and it seems to affect most if not all of them as well.
I searched a bit about that problem, and it seems that only one layerstyle created from the layerstyle dialog can be loaded. It worked fine when I tried copying the layer style and then updated it. Some other unclear tickets could also be linked, such as 452056, 451385, 457553, but I wasn't able to confirm it yet. Speaking about the real reason, it seems that when using the layerstyle dialog, the same uuid is used for all the layerstyles. I tried adding creating a new UUID after the copy of the old style and it seems to work. To put some code here, I changed KisLayerManager::layerStyle, to have > KisPSDLayerStyleSP newStyle = oldStyle->clone().dynamicCast<KisPSDLayerStyle>(); > // We want to also change the UUID, else it might be considered the same style after save and won't load correctly > newStyle->setUuid(QUuid::createUuid()); I'll try to fix that but it's my first time so I can't guarantee anything
Okay, let's set to confirmed. Ideally, we'd get Dmitry to look into this, too, after he's done with his move.
@Ralek could you please check Krita Next and see if this issue is resolved?
Related commits: a84179a80bc8e74505455d0589d07b4cf4283b47 - Don't forget 'align with layer' in gradient layer style e8631c562c511d6b33ea05b93e30000f7ddca852 - Fix color in Bevel and Emboss being forgotten 27aed51669b54356b132d7b6fa18bba90bd94d35 - Fix Bevel and Emboss - Texture Depth not being read from asl 9c847ba5c8ec912bf3c4d318ed5c654a89400418 - Fix layerstyle creation so they are kept after reload
(In reply to Tiar from comment #3) > @Ralek could you please check Krita Next and see if this issue is resolved? I've tested the latest nightly and I can't seem to get it to save layer styles incorrectly, looks good to me!
Setting it to fixed, then :) Thanks for testing!
Master bug of the uuid issue (all issues where the layer style of the duplicated layer is the same as the layer style of the original layer) is bug 457553.