SUMMARY Can't open the 3-dot menu in the following two places: * footer of the Now Playing view * footer of the Playlist sidebar STEPS TO REPRODUCE 1. Press tab until the menu button is highlighted 2. Press enter OBSERVED RESULT Nothing happens EXPECTED RESULT Menu should open SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20230109 KDE Plasma Version: 5.26.5 KDE Frameworks Version: 5.101.0 Qt Version: 5.15.7 Kernel Version: 6.1.3-1-default (64-bit) Graphics Platform: X11 ADDITIONAL INFORMATION
In all of these cases, the 3-dot menu comes from Kirigami.ActionToolbar. That component uses standard Qt focus rules, i.e. "trigger the focused item with the spacebar." However that doesn't work for Elisa since we globally bind the spacebar to "Play/pause" and require the use of the enter/return key instead. We override this for other controls. Me may need new API from ActionToolbar here, or else to port away from that component. Which would be a shame, since it's nice and it solved various other problems we had. Thoughts, Arjen?
I recall Noah working on a patch to Qt so that enter could also be used to trigger controls. I don't recall whether it got merged or not though. That said, worst case we can do a workaround in Kirigami to also make it possible to trigger menus with enter, as I personally think it makes sense.
(In reply to Arjen Hiemstra from comment #2) > I recall Noah working on a patch to Qt so that enter could also be used to > trigger controls. I don't recall whether it got merged or not though. That > said, worst case we can do a workaround in Kirigami to also make it possible > to trigger menus with enter, as I personally think it makes sense. The Qt patch is already completed and backported to Qt5. It's a thing that would need to be configurable though and figuring out where to allow configuring it is a bit of an issue. Maybe keyboard options KCM?
In this case we want to turn it on for Elisa 100% of the time, because the spacebar never works in Elisa to trigger focused UI elements because we made it a global play/pause action. Can we force it on for individual apps?
(In reply to Nate Graham from comment #4) > In this case we want to turn it on for Elisa 100% of the time, because the > spacebar never works in Elisa to trigger focused UI elements because we made > it a global play/pause action. Can we force it on for individual apps? It's implemented as part of the QPlatformTheme. My first thought is you'd need to make a custom QPlatformTheme for Elisa, which would be mad, but I don't really know. Maybe there could be something with private dynamic properties that the platform theme could read from the app and choose the correct behavior. More hacks piled on top, but it's not the worst thing ever.
That does sound crazy; I'd prefer an API in Kirigami.ActionToolBar to say "trigger on enter/return as well" and then when this option is globally enabled in Qt, that defaults to on.
(In reply to Nate Graham from comment #6) > That does sound crazy; I'd prefer an API in Kirigami.ActionToolBar to say > "trigger on enter/return as well" and then when this option is globally > enabled in Qt, that defaults to on. globally enabled in Qt? you still mean only in the scope of the app, right?
Would it be possible to change Elisa so Spacebar is not done globally but only when nothing is focused? Or is something always focused?
Is there a reason we wouldn't just set the property to activate on enter globally in the Plasma platform theme?
(In reply to David Redondo from comment #8) > Would it be possible to change Elisa so Spacebar is not done globally but > only when nothing is focused? Or is something always focused? We had that in the past and it was not good. Nobody liked it. Elisa has a lot of focusable controls and list items, so it was very common for something to become focused and then the spacebar did something unexpected.