Bug 464159 - Database doesn't update immediately when a track is favourited/unfavourited
Summary: Database doesn't update immediately when a track is favourited/unfavourited
Status: CONFIRMED
Alias: None
Product: Elisa
Classification: Applications
Component: general (other bugs)
Version First Reported In: 22.12.1
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: Matthieu Gallien
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-11 16:34 UTC by Jack Hill
Modified: 2023-01-11 20:07 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jack Hill 2023-01-11 16:34:46 UTC 
SUMMARY

STEPS TO REPRODUCE
1. Set the song rating style to "Favourite/not favourite"
2. In the playlist tab, press "Mark this song as favourite"
3. Click the button again

OBSERVED RESULT
Nothing happens, also the tooltip doesn't change

EXPECTED RESULT
The song should be unfavourited. Also the tooltip should change to "Mark this song as not favourite"

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230109
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Kernel Version: 6.1.3-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2023-01-11 18:38:00 UTC 
This should have already been fixed for the 23.04 release; can you confirm with a git master build of the app?
Comment 2 Jack Hill 2023-01-11 19:15:28 UTC 
Yeah, still happens on git master
Comment 3 Jack Hill 2023-01-11 19:40:31 UTC 
Figured out the issue.

Clicking the favourite button makes Elisa update the music *file*, but I don't think the database is updated. Then if you press the button again, the app continues to carry out the same action as before.

Then if you refresh the database (scan for new music) you'll notice the track disappears from the database. Scanning again causes it to reappear with the new rating.
Comment 4 Nate Graham 2023-01-11 20:07:56 UTC 
Can confirm that. Good sleuthing.