Bug 464122 - Make capitalisation of effects names consistent
Summary: Make capitalisation of effects names consistent
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_kwineffects (show other bugs)
Version: 5.26.4
Platform: openSUSE Linux
: NOR minor
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-10 22:34 UTC by John Veness
Modified: 2023-01-11 19:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.27
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Veness 2023-01-10 22:34:46 UTC
STEPS TO REPRODUCE
1. Navigate to System Settings, Workspace Behaviour, Desktop Effects
2. Scroll up and down the list of effects

OBSERVED RESULT
Capitalisation of desktop effect names is inconsistent.

EXPECTED RESULT
Capitalisation of desktop effect names is consistent.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20230109
KDE Plasma Version: 5.26.5
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Kernel Version: 6.1.3-1-default (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i5-7200U CPU @ 2.50GHz
Memory: 15.5 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 620
Manufacturer: HP
Product Name: HP ProBook 450 G4

ADDITIONAL INFORMATION
Most effect names use "Title Case", but a few use "Sentence case", e.g.:

- Background contrast
- Morphing popups
- Sliding popups
Comment 1 Nate Graham 2023-01-11 19:00:44 UTC
Indeed, I found those same three effects that don't use Title Case capitalization. Will fix.
Comment 2 Nate Graham 2023-01-11 19:05:01 UTC
Git commit d312ee24b8ea5c4ae533d29fc644c317464cedd7 by Nate Graham.
Committed on 11/01/2023 at 19:03.
Pushed by ngraham into branch 'master'.

effects: always use Title Case for user-facing effect titles

Most already did, but these three did not, creating inconsistency.
FIXED-IN: 5.27

M  +1    -1    src/effects/backgroundcontrast/metadata.json
M  +1    -1    src/effects/morphingpopups/package/metadata.json
M  +1    -1    src/effects/slidingpopups/metadata.json

https://invent.kde.org/plasma/kwin/commit/d312ee24b8ea5c4ae533d29fc644c317464cedd7
Comment 3 John Veness 2023-01-11 19:14:00 UTC
Thanks Nate!
Comment 4 Nate Graham 2023-01-11 19:14:32 UTC
You're welcome!