Bug 463746 - Inconsistency between KIO::JobUiDelegate MessageBoxes and Kirigami overlay popups
Summary: Inconsistency between KIO::JobUiDelegate MessageBoxes and Kirigami overlay po...
Status: CONFIRMED
Alias: None
Product: frameworks-kirigami
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.101.0
Platform: Other Linux
: LO wishlist
Target Milestone: Not decided
Assignee: kdelibs bugs
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2023-01-02 19:13 UTC by Alexander Wilms
Modified: 2023-01-09 19:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Kirigami prompt (321.12 KB, image/png)
2023-01-02 19:13 UTC, Alexander Wilms
Details
Regular prompt (294.55 KB, image/png)
2023-01-02 19:14 UTC, Alexander Wilms
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Wilms 2023-01-02 19:13:44 UTC
Created attachment 154969 [details]
Kirigami prompt

SUMMARY
KIO::JobUiDelegate MessageBoxes like [1] and Kirigami both seem to fill the same role, but are inconsistent regarding their style.


STEPS TO REPRODUCE
1. Open Dolphin, delete a file, open trash:/, empty trash
2. Open System Setting, navigate to Appearance > Global Theme, select another global theme, click cancel in prompt
3. Switch to another KCM

OBSERVED RESULT
In cases 1 and 3, the message box is styled like a regular Qt dialog and the entire parent window is greyed out.
In case 2, a window appears with a swiping animation and has an entirely different style. Only the KCM is greyed out.



EXPECTED RESULT
All message boxes look like the one Dolphin shows.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7

ADDITIONAL INFORMATION
[1] https://invent.kde.org/system/dolphin/-/blob/1d04d04cf301e82971d90cceb541f368192e2167/src/trash/dolphintrash.cpp#L73
Comment 1 Alexander Wilms 2023-01-02 19:14:05 UTC
Created attachment 154970 [details]
Regular prompt
Comment 2 Nate Graham 2023-01-09 19:04:10 UTC
There isn't really a way to make them consistent. One is a real window, one is a popup inside a window.

The fact that in System Settings, only part of the window becomes darkened is an unfortunate bug due to System Settings' architecture of being half QtWidgets and half QtQuick. It's not easily fixable without rewriting System Settings to be 100% QtWidgets, or changing the darkening effect so that it's no longer done by Kirigami itself, but rather it calls into the KWin effect to do it to the whole window when needed. But then the popup itself would be darkened too since technically it's just ordinary window content. So some clever workaround would need to be made for that. And note that that effect is currently broken on Wayland: Bug 460819.

Or, we could abandon in-window popups and always use real windows. But this would be a massive undertaking and it's kind of not what we want anyway.