Bug 463520 - [5.2.0 Nightly] Brush setting panel (F5) changing center width and cutoff brush presets and scratchpad side panels
Summary: [5.2.0 Nightly] Brush setting panel (F5) changing center width and cutoff bru...
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (other bugs)
Version First Reported In: nightly build (please specify the git hash!)
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-27 13:42 UTC by Protoniv
Modified: 2023-08-30 20:58 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
(F5) The center "property" area expand when turn on side panel (953.21 KB, video/mp4)
2022-12-27 13:42 UTC, Protoniv
Details
(F6) Flash wider and back when first open it after krita launch (188.52 KB, video/mp4)
2022-12-27 13:47 UTC, Protoniv
Details
on Windows 5.2.0 nightly build #1962 (1.71 MB, video/mp4)
2023-01-04 12:01 UTC, Protoniv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Protoniv 2022-12-27 13:42:49 UTC
Created attachment 154847 [details]
(F5) The center "property" area expand when turn on side panel

SUMMARY
There are two issue:
1. Brush preset popup panel (F6) will flash to a wider width and then flash back, only happen when the first time you open it after launching krita.
2. Brush setting (F5) in popup mode, "center width" will become wider when turn on left/right side panel.
Detach brush editor will make it not auto expand its window when turn on left/right side panel.

krita-5.2.0-prealpha-7339c1651b-x86_64.appimage

ADDITIONAL INFORMATION
Seems happened after MR 1670 merged?
Comment 1 Protoniv 2022-12-27 13:47:53 UTC
Created attachment 154848 [details]
(F6) Flash wider and back when first open it after krita launch

The first F5 attachment have some recording issue, causing flicker at the top, **only** in record video.
Comment 2 Halla Rempt 2023-01-04 11:12:46 UTC
Could you please check whether this is still the case? I cannot reproduce it anymore in the latest build from master I've tested.

This might've fixed it:

commit 873445ce6c7a54d59ed7f55da491cbdf2c49ab40
Author: Măcelaru Tiberiu <polecattibi@gmail.com>
Date:   Tue Dec 13 21:31:19 2022 +0200

    This should fix the size issues with the Brush Editor.
    Brush Editor is more responsive it now uses QSplitter also to allow for resizing.
    Replaced the usage of KisPresetChooserStrip with KisPresetChooser and rewired and
    deleted some UI stuff.
    
    In the next one I will move the awfull side arrow buttons to the bottom bar below
    and fix some QSplitter behaviour.
Comment 3 Protoniv 2023-01-04 12:01:48 UTC
Created attachment 155022 [details]
on Windows 5.2.0 nightly build #1962

(In reply to Halla Rempt from comment #2)
> Could you please check whether this is still the case? I cannot reproduce it
> anymore in the latest build from master I've tested.
Yes, still reproduceable in nightly build today (Windows build #1962), test with another computer
Attach another video recorded from this build.
(The brush editor left side panel should have 4 rows width for that icon size)
Comment 4 Bug Janitor Service 2023-01-05 05:27:49 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 5 wolthera 2023-01-11 21:14:01 UTC
I can confirm with the Krita Version: 5.2.0-prealpha (git 5c98a72) Appimage with Qt 5.15.7

No clue what causes it though...
Comment 6 Dmitry Kazakov 2023-07-26 12:32:22 UTC
Git commit 339cb7ef7d5b3783b8c592ecf7284496178bf13e by Dmitry Kazakov, on behalf of Freya Lupen.
Committed on 26/07/2023 at 14:32.
Pushed by dkazakov into branch 'master'.

Fix preset chooser resizing itself on first open

Make sure horizontal mode switching is only enabled for the
Brush Preset Docker which it's intended for, and that vertical layout
is set when creating the widget and not later. Otherwise the
toolbar Presets popup will noticeably resize itself when first opened.

M  +2    -3    libs/resourcewidgets/KisResourceItemChooser.cpp
M  +5    -0    libs/ui/widgets/kis_paintop_presets_chooser_popup.cpp
M  +1    -0    libs/ui/widgets/kis_paintop_presets_chooser_popup.h
M  +0    -1    libs/ui/widgets/kis_preset_chooser.cpp
M  +1    -0    plugins/dockers/presetdocker/presetdocker_dock.cpp

https://invent.kde.org/graphics/krita/-/commit/339cb7ef7d5b3783b8c592ecf7284496178bf13e
Comment 7 Dmitry Kazakov 2023-07-26 12:32:51 UTC
Git commit 1f43b81bcf981ddce8b13633bf2ebd16c9c7461e by Dmitry Kazakov, on behalf of Freya Lupen.
Committed on 26/07/2023 at 14:32.
Pushed by dkazakov into branch 'krita/5.2'.

Fix preset chooser resizing itself on first open

Make sure horizontal mode switching is only enabled for the
Brush Preset Docker which it's intended for, and that vertical layout
is set when creating the widget and not later. Otherwise the
toolbar Presets popup will noticeably resize itself when first opened.


(cherry picked from commit 339cb7ef7d5b3783b8c592ecf7284496178bf13e)

M  +2    -3    libs/resourcewidgets/KisResourceItemChooser.cpp
M  +5    -0    libs/ui/widgets/kis_paintop_presets_chooser_popup.cpp
M  +1    -0    libs/ui/widgets/kis_paintop_presets_chooser_popup.h
M  +0    -1    libs/ui/widgets/kis_preset_chooser.cpp
M  +1    -0    plugins/dockers/presetdocker/presetdocker_dock.cpp

https://invent.kde.org/graphics/krita/-/commit/1f43b81bcf981ddce8b13633bf2ebd16c9c7461e
Comment 8 Dmitry Kazakov 2023-08-21 16:10:59 UTC
I guess the bug should be fixed now. Protoniv, could you please check if the bug is still present in Krita 5.2 Beta2?
Comment 9 Protoniv 2023-08-30 20:58:03 UTC
(In reply to Dmitry Kazakov from comment #8)
> I guess the bug should be fixed now. Protoniv, could you please check if the
> bug is still present in Krita 5.2 Beta2?

Sorry for the late reply, it is now mostly fixed in 5.2.0 Beta2.
And the Brush editor (F5) left panel (still appears in 2-row width instead of 4) can now remember user's width adjustment in 5.3.0-prealpha, I think it can now marked as resolved.