Bug 463490 - selecting the same channel twice (for example by clicking on it) causes the messages view to stop updating
Summary: selecting the same channel twice (for example by clicking on it) causes the m...
Status: RESOLVED FIXED
Alias: None
Product: Ruqola
Classification: Applications
Component: frontend (other bugs)
Version First Reported In: unspecified
Platform: Other Other
: NOR normal
Target Milestone: ---
Assignee: Laurent Montel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-26 14:42 UTC by Till Adam
Modified: 2023-01-10 07:21 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/network/ruqola/commit/1b2ecd8854ad018c2578198cb889aa225800d79f
Version Fixed/Implemented In: 1.9.1
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Till Adam 2022-12-26 14:42:47 UTC 
SUMMARY
***
NOTE: If you are reporting a crash, please try to attach a backtrace with debug symbols.
See https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports
***
Selecting the same channel twice in a row, for example by clicking on it twice, causes the messages list view to stop updating when new messages come in or when one types into the chat oneself.

STEPS TO REPRODUCE
1. click on channel in the list of channels
2. click on the same channel again
3. type into message line edit 

OBSERVED RESULT
new message does not appear

EXPECTED RESULT
new message should appear

Reproducible on Linux and Mac, at least.
Comment 1 Bug Janitor Service 2022-12-26 14:45:27 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/network/ruqola/-/merge_requests/106
Comment 2 Laurent Montel 2023-01-10 07:21:05 UTC 
Git commit 998db477c5021b481672f6a2cabfa3682338637d by Laurent Montel.
Committed on 10/01/2023 at 07:20.
Pushed by mlaurent into branch '1.9'.

Fix selecting the same channel twice (for example by clicking on it) causes the messages view to stop updating
FIXED-IN: 1.9.1

M  +12   -0    src/widgets/channellist/channellistview.cpp
M  +2    -0    src/widgets/channellist/channellistview.h
M  +1    -0    src/widgets/channellist/channellistwidget.cpp
M  +1    -0    src/widgets/channellist/channellistwidget.h
M  +5    -0    src/widgets/room/roomwidget.cpp
M  +2    -0    src/widgets/room/roomwidget.h
M  +9    -0    src/widgets/ruqolamainwidget.cpp
M  +1    -0    src/widgets/ruqolamainwidget.h

https://invent.kde.org/network/ruqola/commit/998db477c5021b481672f6a2cabfa3682338637d
Comment 3 Laurent Montel 2023-01-10 07:21:41 UTC 
Git commit 1b2ecd8854ad018c2578198cb889aa225800d79f by Laurent Montel.
Committed on 10/01/2023 at 07:21.
Pushed by mlaurent into branch 'master'.

Fix selecting the same channel twice (for example by clicking on it) causes the messages view to stop updating
FIXED-IN: 1.9.1

M  +12   -0    src/widgets/channellist/channellistview.cpp
M  +2    -0    src/widgets/channellist/channellistview.h
M  +1    -0    src/widgets/channellist/channellistwidget.cpp
M  +1    -0    src/widgets/channellist/channellistwidget.h
M  +5    -0    src/widgets/room/roomwidget.cpp
M  +2    -0    src/widgets/room/roomwidget.h
M  +9    -0    src/widgets/ruqolamainwidget.cpp
M  +1    -0    src/widgets/ruqolamainwidget.h

https://invent.kde.org/network/ruqola/commit/1b2ecd8854ad018c2578198cb889aa225800d79f