Bug 463443 - Comics Manager gives error when creating a page
Summary: Comics Manager gives error when creating a page
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Dockers (other bugs)
Version First Reported In: 5.1.4
Platform: Kubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-24 19:31 UTC by Faustino Vonner
Modified: 2023-06-20 20:47 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Comic Manager Error video (2.60 MB, video/mp4)
2022-12-24 19:31 UTC, Faustino Vonner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Faustino Vonner 2022-12-24 19:31:09 UTC
Created attachment 154813 [details]
Comic Manager Error video

SUMMARY
***
STEPS TO REPRODUCE
1. Open Comics manager docker
2. Select a folder for comics
3. Click on Add page

OBSERVED RESULT
Gives error: TypeError: createDocument(self, width: int, height: int, name: str, colorModel: str, colorDepth: str, profile: str, resolution: float): argument 1 has unexpected type ‘float’

EXPECTED RESULT
Kirta Adds a comic page

SOFTWARE/OS VERSIONS
 
Linux/KDE Plasma: Kubuntu 22.04.1 LTS x86_64, Kernel 5.15.0-56-generic(64-bit)
KDE Plasma Version: 5.24.7
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
Error Log:
TypeError
Python 3.10.6: /usr/bin/python3
Sun Dec 25 00:30:38 2022

A problem occurred in a Python script.  Here is the sequence of
function calls leading up to the error, in the order they occurred.

 /app/share/krita/pykrita/comics_project_management_tools/comics_template_dialog.py in slot_create_template(self=<comics_project_management_tools.comics_template_dialog.comics_template_dialog object>)
  112 
  113         if create.exec_() == QDialog.Accepted:
  114             if (create.prepare_krita_file()):
  115                 self.fill_templates()
  116 
create = <comics_project_management_tools.comics_template_dialog.comics_template_create object>
create.prepare_krita_file = <bound method comics_template_create.prepare_kri...s_template_dialog.comics_template_create object>>

 /app/share/krita/pykrita/comics_project_management_tools/comics_template_dialog.py in prepare_krita_file(self=<comics_project_management_tools.comics_template_dialog.comics_template_create object>)
  298         mB = self.marginBottomUnit.pixelsForUnit(self.marginBottom.value(), self.DPI.value())
  299 
  300         template = Application.createDocument((wBase + bL + bR), (hBase + bT + bB), self.templateName.text(), "RGBA", "U8", "sRGB built-in", self.DPI.value())
  301 
  302         backgroundName = i18n("Background")
template undefined
builtinApplication = <PyKrita.krita.Krita object>
Application.createDocument = <built-in method createDocument of Krita object>
wBase = 3300.0
bL = 150.0
bR = 150.0
hBase = 5100.0
bT = 300.0
bB = 300.0
self = <comics_project_management_tools.comics_template_dialog.comics_template_create object>
self.templateName = <PyQt5.QtWidgets.QLineEdit object>
self.templateName.text = <built-in method text of QLineEdit object>
self.DPI = <PyQt5.QtWidgets.QSpinBox object>
self.DPI.value = <built-in method value of QSpinBox object>
TypeError: createDocument(self, width: int, height: int, name: str, colorModel: str, colorDepth: str, profile: str, resolution: float): argument 1 has unexpected type 'float'
    __cause__ = None
    __class__ = <class 'TypeError'>
    __context__ = None
    __delattr__ = <method-wrapper '__delattr__' of TypeError object>
    __dict__ = {}
    __dir__ = <built-in method __dir__ of TypeError object>
    __doc__ = 'Inappropriate argument type.'
    __eq__ = <method-wrapper '__eq__' of TypeError object>
    __format__ = <built-in method __format__ of TypeError object>
    __ge__ = <method-wrapper '__ge__' of TypeError object>
    __getattribute__ = <method-wrapper '__getattribute__' of TypeError object>
    __gt__ = <method-wrapper '__gt__' of TypeError object>
    __hash__ = <method-wrapper '__hash__' of TypeError object>
    __init__ = <method-wrapper '__init__' of TypeError object>
    __init_subclass__ = <built-in method __init_subclass__ of type object>
    __le__ = <method-wrapper '__le__' of TypeError object>
    __lt__ = <method-wrapper '__lt__' of TypeError object>
    __ne__ = <method-wrapper '__ne__' of TypeError object>
    __new__ = <built-in method __new__ of type object>
    __reduce__ = <built-in method __reduce__ of TypeError object>
    __reduce_ex__ = <built-in method __reduce_ex__ of TypeError object>
    __repr__ = <method-wrapper '__repr__' of TypeError object>
    __setattr__ = <method-wrapper '__setattr__' of TypeError object>
    __setstate__ = <built-in method __setstate__ of TypeError object>
    __sizeof__ = <built-in method __sizeof__ of TypeError object>
    __str__ = <method-wrapper '__str__' of TypeError object>
    __subclasshook__ = <built-in method __subclasshook__ of type object>
    __suppress_context__ = False
    __traceback__ = <traceback object>
    args = ("createDocument(self, width: int, height: int, na...n: float): argument 1 has unexpected type 'float'",)
    with_traceback = <built-in method with_traceback of TypeError object>

The above is a description of an error in a Python program.  Here is
the original traceback:

Traceback (most recent call last):
  File "/app/share/krita/pykrita/comics_project_management_tools/comics_template_dialog.py", line 114, in slot_create_template
    if (create.prepare_krita_file()):
  File "/app/share/krita/pykrita/comics_project_management_tools/comics_template_dialog.py", line 300, in prepare_krita_file
    template = Application.createDocument((wBase + bL + bR), (hBase + bT + bB), self.templateName.text(), "RGBA", "U8", "sRGB built-in", self.DPI.value())
TypeError: createDocument(self, width: int, height: int, name: str, colorModel: str, colorDepth: str, profile: str, resolution: float): argument 1 has unexpected type 'float'
Comment 1 Halla Rempt 2023-01-04 11:53:51 UTC
I've tried to reproduce this, but failed. Can you reproduce this with the appimage, or only with the distribution packages?
Comment 2 Faustino Vonner 2023-01-04 19:18:30 UTC
No, i Just checked and it's not happening in the appimages. Only flatpak and the distribution packages.
Comment 3 Halla Rempt 2023-01-05 10:26:52 UTC
Then it's probably a regression in Qt itself. For appimage, we're still using Qt 5.12, though we are trying to port to Qt 5.15 -- and then we will need to test for this issue.
Comment 4 Halla Rempt 2023-01-06 11:27:37 UTC
5.15 TEST
Comment 5 Faustino Vonner 2023-01-07 23:37:21 UTC
(In reply to Halla Rempt from comment #4)
> 5.15 TEST

I'm sorry i'm not a developer so i don't know what to do here.
Comment 6 Halla Rempt 2023-01-08 09:16:03 UTC
Nothing, this is just an internal code telling us to test this bug once we've landed the update from Qt 5.12 to Qt 5.15.
Comment 7 Freya Lupen 2023-06-20 20:47:05 UTC
Fixed in https://invent.kde.org/graphics/krita/-/commit/07a703195b1f821aa03090eaaf32514d589cb734 (5.2.0-prealpha).