Bug 463398 - Predefined keywords are not remembered
Summary: Predefined keywords are not remembered
Status: RESOLVED FIXED
Alias: None
Product: KBibTeX
Classification: Applications
Component: General (show other bugs)
Version: 0.9.2
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-23 15:31 UTC by Axel Schwank
Modified: 2023-01-04 22:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.3
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Axel Schwank 2022-12-23 15:31:48 UTC
SUMMARY
***
KBibTeX does not remember keywords from preferences
***


STEPS TO REPRODUCE
1. Open KBibTeX settings (Settings -> Configure KBibTex...)
2. Go to General -> Keywords
3. Add some keywords
4. Press OK Button

OBSERVED RESULT
Go to settings again. All keywords are lost.

EXPECTED RESULT
Keywords are rememberes.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: openSuSE Tumbleweed
(available in About System)
KDE Plasma Version: 5.26.3
KDE Frameworks Version: 5.100.0
Qt Version: 5.15.7

ADDITIONAL INFORMATION
Comment 1 Thomas Fischer 2023-01-01 22:33:34 UTC
I can confirm this bug. Can you please check the latest commit in the 'kbibtex/0.9' in my personal Git repository (not KBibTeX's official one)?
https://invent.kde.org/thomasfischer/kbibtex/commit/3d32f7724f1471a355a2aad7487a82e6dd1a067d

You should be able to test this code with a small helper script I have published in a separate repository. Please perform the following steps:
0. Uninstall the distribution-provided KBibTeX installation (not sure if actually necessary; try if problems in following steps arise)
1. Get this script:  https://invent.kde.org/thomasfischer/kbibtex-related/-/raw/master/run/run-kbibtex.sh?inline=false
2. Run as normal user:   bash run-kbibtex.sh https://invent.kde.org/thomasfischer/kbibtex.git kbibtex/0.9

None of the steps above requires root/sudo/su as everything happens in /tmp. If cmake complains about missing development libraries, simply install those via your Linux distribution's package manager and restart the script. Later, you can remove those packages if you see no further need.
Comment 2 Axel Schwank 2023-01-02 16:47:09 UTC
Hi Thomas,
that looks good. I can confirm the bug is fixed. Thank you.

Best regards
Axel
Comment 3 Thomas Fischer 2023-01-02 22:14:32 UTC
Git commit 3d32f7724f1471a355a2aad7487a82e6dd1a067d by Thomas Fischer.
Committed on 01/01/2023 at 21:29.
Pushed by thomasfischer into branch 'kbibtex/0.9'.

Predefined keywords are not remembered

When the list of predefined keywords in the settings dialog is changed
(keyword added, removed, or modified), those changes should trigger a
status changed that this dialog's settings got changed and therefore
should get applied when the user clicks "Ok" or "Apply".

M  +3    -1    src/gui/preferences/settingsglobalkeywordswidget.cpp

https://invent.kde.org/office/kbibtex/commit/3d32f7724f1471a355a2aad7487a82e6dd1a067d
Comment 4 Thomas Fischer 2023-01-03 22:07:12 UTC
Git commit a71b5d77862a696f0b4da432607b35c04eafe989 by Thomas Fischer.
Committed on 02/01/2023 at 23:09.
Pushed by thomasfischer into branch 'kbibtex/0.10'.

Predefined keywords are not remembered

When the list of predefined keywords in the settings dialog is changed
(keyword added, removed, or modified), those changes should trigger a
status changed that this dialog's settings got changed and therefore
should get applied when the user clicks "Ok" or "Apply".

This commit is a forward port of commit 3d32f7724f1471a355a2aad7487 from
branch 'kbibtex/0.9', but test 'settingsGlobalKeywordsWidgetAddRemove'
in 'KBibTeXGUITest' was added only in this commit here.

M  +1    -0    CMakeLists.txt
M  +3    -1    src/gui/preferences/settingsglobalkeywordswidget.cpp
M  +4    -0    src/gui/preferences/settingsglobalkeywordswidget.h
M  +19   -0    src/test/kbibtexguitest.cpp

https://invent.kde.org/office/kbibtex/commit/a71b5d77862a696f0b4da432607b35c04eafe989
Comment 5 Thomas Fischer 2023-01-04 22:02:03 UTC
Git commit cad23e2ada3515cc78a88ece1647eec3fb77708a by Thomas Fischer.
Committed on 04/01/2023 at 22:00.
Pushed by thomasfischer into branch 'master'.

Predefined keywords are not remembered

When the list of predefined keywords in the settings dialog is changed
(keyword added, removed, or modified), those changes should trigger a
status changed that this dialog's settings got changed and therefore
should get applied when the user clicks "Ok" or "Apply".

This commit is a forward port of commit a71b5d77862a696f0b4da4326 from
branch 'kbibtex/0.10'.

M  +1    -0    CMakeLists.txt
M  +3    -1    src/gui/preferences/settingsglobalkeywordswidget.cpp
M  +4    -0    src/gui/preferences/settingsglobalkeywordswidget.h
M  +19   -0    src/test/kbibtexguitest.cpp

https://invent.kde.org/office/kbibtex/commit/cad23e2ada3515cc78a88ece1647eec3fb77708a