Bug 463103 - Some messages are not showed localized
Summary: Some messages are not showed localized
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Unmaintained
Component: Picture of the Day (other bugs)
Version First Reported In: 5.26.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-16 06:50 UTC by Paolo Zamponi
Modified: 2023-01-17 05:39 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.26.5
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paolo Zamponi 2022-12-16 06:50:53 UTC
SUMMARY

STEPS TO REPRODUCE
1. Right click on an empty area of the desktop
2. Choose "Configure Desktop and Wallpaper…	"
3. Choose "Today's picture" as "Wallpaper type:"

OBSERVED RESULT
"Update when using metered network connection", "Today's picture:", "Title" and "Author" are always displayed in English (tried in various languages).

EXPECTED RESULT
Those messages should be shown localized.

SOFTWARE/OS VERSIONS
Operating System: openSUSE Tumbleweed 20221214
KDE Plasma Version: 5.26.4
KDE Frameworks Version: 5.101.0
Qt Version: 5.15.7
Kernel Version: 6.0.12-1-default (64-bit)
Graphics Platform: X11

ADDITIONAL INFORMATION
If I change in config.qml the 4 related "i18nc(..." with "i18ndc("plasma_wallpaper_org.kde.potd...", which is the name of the .po file, it works.
Comment 1 Fushan Wen 2022-12-16 07:33:46 UTC
Thanks for reporting.! Are you interested in submitting a merge request to fix the translation?
Comment 2 Paolo Zamponi 2022-12-16 07:35:56 UTC
I'm trying...
Comment 3 Paolo Zamponi 2022-12-16 08:16:04 UTC
It says "Permission denied (publickey)." when I try to push the fork...

Anyway the most important thing is that someone fix it :) ...
Comment 4 Fushan Wen 2022-12-16 08:22:09 UTC
(In reply to Paolo Zamponi from comment #3)
> It says "Permission denied (publickey)." when I try to push the fork...
> 
> Anyway the most important thing is that someone fix it :) ...

Perhaps you need to enable 2FA, or add your public key to GitLab
Comment 5 Paolo Zamponi 2022-12-16 13:27:33 UTC
I'm following this guide (https://community.kde.org/Infrastructure/GitLab#Submitting_a_Merge_Request) and everything seems went well before that point.

Since I'm a translator and I can commit translations, I've added a key in Invent. Should I use that key before the push?

If yes, can I resume my submitting process from that point?

Thank you
Comment 6 Fushan Wen 2022-12-17 14:12:17 UTC
Git commit 22bb611e46fa51213a88d1f575b4c4f9d8b073a0 by Fushan Wen.
Committed on 17/12/2022 at 14:08.
Pushed by fusionfuture into branch 'master'.

wallpapers/potd: use `i18ndc` to specify translation domain
FIXED-IN: 5.27

M  +6    -6    wallpapers/potd/package/contents/ui/WallpaperDelegate.qml
M  +4    -4    wallpapers/potd/package/contents/ui/WallpaperPreview.qml
M  +6    -6    wallpapers/potd/package/contents/ui/config.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/22bb611e46fa51213a88d1f575b4c4f9d8b073a0
Comment 7 Fushan Wen 2022-12-17 14:17:41 UTC
Git commit 006d751eac83750a81b69ccff50bcc658704d1c2 by Fushan Wen.
Committed on 17/12/2022 at 14:15.
Pushed by fusionfuture into branch 'Plasma/5.26'.

wallpapers/potd: use `i18ndc` to specify translation domain
FIXED-IN: 5.26.5

(cherry picked from commit 22bb611e46fa51213a88d1f575b4c4f9d8b073a0)

M  +6    -6    wallpapers/potd/package/contents/ui/WallpaperDelegate.qml
M  +4    -4    wallpapers/potd/package/contents/ui/WallpaperPreview.qml
M  +6    -6    wallpapers/potd/package/contents/ui/config.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/006d751eac83750a81b69ccff50bcc658704d1c2
Comment 8 Fushan Wen 2022-12-17 14:18:24 UTC
(In reply to Paolo Zamponi from comment #5)
> I'm following this guide
> (https://community.kde.org/Infrastructure/GitLab#Submitting_a_Merge_Request)
> and everything seems went well before that point.
> 
> Since I'm a translator and I can commit translations, I've added a key in
> Invent. Should I use that key before the push?
> 
> If yes, can I resume my submitting process from that point?
> 
> Thank you

Don't really have idea what could be wrong, so I just did some simple replacement.
Comment 9 Paolo Zamponi 2022-12-17 14:21:01 UTC
(In reply to Fushan Wen from comment #8)
> (In reply to Paolo Zamponi from comment #5)
> > I'm following this guide
> > (https://community.kde.org/Infrastructure/GitLab#Submitting_a_Merge_Request)
> > and everything seems went well before that point.
> > 
> > Since I'm a translator and I can commit translations, I've added a key in
> > Invent. Should I use that key before the push?
> > 
> > If yes, can I resume my submitting process from that point?
> > 
> > Thank you
> 
> Don't really have idea what could be wrong, so I just did some simple
> replacement.

Ok, don't worry, thank you
Comment 10 Bug Janitor Service 2023-01-15 05:00:19 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/324
Comment 11 Fushan Wen 2023-01-16 06:38:23 UTC
Git commit dd22cbd50f2eaf420c8968630d8253e83a6da73e by Fushan Wen.
Committed on 16/01/2023 at 06:37.
Pushed by fusionfuture into branch 'master'.

wallpapers/potd: use `i18ndc` to specify translation domain

M  +8    -7    wallpapers/potd/plugins/potdbackend.cpp

https://invent.kde.org/plasma/kdeplasma-addons/commit/dd22cbd50f2eaf420c8968630d8253e83a6da73e
Comment 12 Bug Janitor Service 2023-01-17 05:20:16 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/325
Comment 13 Bug Janitor Service 2023-01-17 05:39:54 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/2508