Bug 462897 - [kde-dev-scripts] {qt4,kf5}/functionUtilkde.pm : Error in sub diffFile
Summary: [kde-dev-scripts] {qt4,kf5}/functionUtilkde.pm : Error in sub diffFile
Status: RESOLVED FIXED
Alias: None
Product: kdesdk-scripts
Classification: Developer tools
Component: Miscellaneous (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Oliver Kellogg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-11 11:06 UTC by Oliver Kellogg
Modified: 2022-12-27 09:14 UTC (History)
0 users

See Also:
Latest Commit: https://invent.kde.org/sdk/kde-dev-scripts/commit/33fdd2f30ff4701d8a1c7abcdf1e32dc16bf678f
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
{qt4,kf5}/functionUtilkde.pm : In sub diffFile use @_ in lieu of $@. (1.39 KB, patch)
2022-12-11 11:12 UTC, Oliver Kellogg 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Kellogg 2022-12-11 11:06:21 UTC 
SUMMARY
***
kde-dev-scripts : Error in sub diffFile of qt4/functionUtilkde.pm and kf5/functionUtilkde.pm
***

STEPS TO REPRODUCE
Run any of the scripts that call functionUtilkde::diffFile.

OBSERVED RESULT
When using git, there will be the error
"fatal: empty string is not a valid pathspec. please use . instead if you meant to match all paths".
The problem is also present for the other supported version control systems (svn, hg, cvs).

EXPECTED RESULT
A "diff" of the file given as argument to functionUtilkde::diffFile shall appear.

SOFTWARE/OS VERSIONS
Git master: The problem was introduced by commit 002eac6 on Jul 5, 2013.
Comment 1 Oliver Kellogg 2022-12-11 11:12:24 UTC 
Created attachment 154493 [details]
{qt4,kf5}/functionUtilkde.pm : In sub diffFile use @_ in lieu of $@.

The attachment bug462897-functionUtilkde-diffFile-fix.diff fixes the problem.
Comment 2 Oliver Kellogg 2022-12-27 09:14:02 UTC 
Git commit 33fdd2f30ff4701d8a1c7abcdf1e32dc16bf678f by Oliver Kellogg.
Committed on 27/12/2022 at 09:12.
Pushed by okellogg into branch 'master'.

{qt4,kf5}/functionUtilkde.pm : In sub diffFile use @_ in lieu of $@.

M  +4    -4    kf5/functionUtilkde.pm
M  +4    -4    qt4/functionUtilkde.pm

https://invent.kde.org/sdk/kde-dev-scripts/commit/33fdd2f30ff4701d8a1c7abcdf1e32dc16bf678f